[SES-3869] Fixed blinded contacts not deleted after accepting blind requests (#1530)

* Fixed blinded contacts not deleted after accepting blind requests

* Only update once

Author: SessionHero01

app/src/main/java/org/session/libsession/messaging/sending_receiving/MessageRequestResponseHandler.kt

@@ -128,16 +128,24 @@ class MessageRequestResponseHandler @Inject constructor(
                         moveConversation(fromThreadId = blindedThreadId, toThreadId = threadId)
                     }
 
-                // If we ever have any blinded conversations with this sender, we should make
-                // sure we have set "approved" to true for them, because when we started the blinded
-                // conversation, we didn't know their real standard addresses, so we didn't say
-                // we have approved them, but now that we do, we need to approve them.
-                if (existingBlindedThreadIDs.isNotEmpty()) {
-                    configFactory.withMutableUserConfigs { configs ->
+                configFactory.withMutableUserConfigs { configs ->
+                    // If we ever have any blinded conversations with this sender, we should make
+                    // sure we have set "approved" to true for them, because when we started the blinded
+                    // conversation, we didn't know their real standard addresses, so we didn't say
+                    // we have approved them, but now that we do, we need to approve them.
+                    if (existingBlindedThreadIDs.isNotEmpty()) {
                         configs.contacts.updateContact(messageSender.address) {
                             approved = true
                         }
                     }
+
+                    // Also remove all blinded contacts
+                    for (address in blindedConversationAddresses) {
+                        configs.contacts.eraseBlinded(
+                            communityServerUrl = address.serverUrl,
+                            blindedId = address.blindedId.address
+                        )
+                    }
                 }
             }