Fix app bar jumping (#1447)

Author: SessionHero01

app/src/main/java/org/thoughtcrime/securesms/ui/components/ConversationAppBar.kt

@@ -12,14 +12,14 @@ import androidx.compose.foundation.layout.Column
 import androidx.compose.foundation.layout.Row
 import androidx.compose.foundation.layout.Spacer
 import androidx.compose.foundation.layout.WindowInsets
-import androidx.compose.foundation.layout.asPaddingValues
 import androidx.compose.foundation.layout.fillMaxWidth
 import androidx.compose.foundation.layout.height
 import androidx.compose.foundation.layout.heightIn
 import androidx.compose.foundation.layout.padding
 import androidx.compose.foundation.layout.size
 import androidx.compose.foundation.layout.systemBars
 import androidx.compose.foundation.layout.width
+import androidx.compose.foundation.layout.windowInsetsTopHeight
 import androidx.compose.foundation.pager.HorizontalPager
 import androidx.compose.foundation.pager.PagerState
 import androidx.compose.foundation.pager.rememberPagerState
@@ -40,7 +40,6 @@ import androidx.compose.ui.draw.rotate
 import androidx.compose.ui.focus.FocusRequester
 import androidx.compose.ui.focus.focusRequester
 import androidx.compose.ui.graphics.ColorFilter
-import androidx.compose.ui.platform.LocalDensity
 import androidx.compose.ui.res.painterResource
 import androidx.compose.ui.res.stringResource
 import androidx.compose.ui.text.style.TextAlign
@@ -78,21 +77,14 @@ fun ConversationAppBar(
     onAvatarPressed: () -> Unit,
     modifier: Modifier = Modifier
 ) {
-    val statusBarHeight = with(LocalDensity.current) {
-        WindowInsets.systemBars.asPaddingValues().calculateTopPadding()
-    }
-
-    Box (
-        modifier = modifier.padding(top = statusBarHeight)
-    ) {
+    Box(modifier = modifier) {
         // cross fade between the default app bar and the search bar
         Crossfade(targetState = data.showSearch) { showSearch ->
             when(showSearch){
                 false -> {
                     val pagerState = rememberPagerState(pageCount = { data.pagerData.size })
 
                     CenterAlignedTopAppBar(
-                        windowInsets = WindowInsets(0, 0, 0, 0),
                         title = {
                             Column(
                                 horizontalAlignment = Alignment.CenterHorizontally
@@ -170,7 +162,9 @@ fun ConversationAppBar(
 
                 true -> {
                     Row(
-                        modifier = Modifier.padding(horizontal = LocalDimensions.current.smallSpacing)
+                        modifier = Modifier
+                            .windowInsetsTopHeight(WindowInsets.systemBars)
+                            .padding(horizontal = LocalDimensions.current.smallSpacing)
                             .heightIn(min = LocalDimensions.current.appBarHeight),
                         verticalAlignment = Alignment.CenterVertically,
                     ) {