refactor: centralize pro context declaration

Author: mikimandoki

run/test/specs/message_length.spec.ts

@@ -14,7 +14,7 @@ import {
 import { CTAButtonNegative } from '../locators/global';
 import { PlusButton } from '../locators/home';
 import { EnterAccountID, NewMessageOption, NextButton } from '../locators/start_conversation';
-import { IOSTestContext } from '../utils/capabilities_ios';
+import { IOS_PRO_CONTEXT } from '../utils/capabilities_ios';
 import { newUser } from '../utils/create_account';
 import { makeAccountPro } from '../utils/mock_pro';
 import { closeApp, openAppOnPlatformSingleDevice, SupportedPlatformsType } from '../utils/open_app';
@@ -87,11 +87,8 @@ for (const testCase of messageLengthTestCases) {
     },
     allureDescription: `Verifies message length behavior at ${testCase.length} characters - ${testCase.description} (${proSuffix})`,
     testCb: async (platform: SupportedPlatformsType, testInfo: TestInfo) => {
-      const iosContext: IOSTestContext = {
-        sessionProEnabled: 'true',
-      };
       const { device, alice } = await test.step(TestSteps.SETUP.NEW_USER, async () => {
-        const { device } = await openAppOnPlatformSingleDevice(platform, testInfo, iosContext);
+        const { device } = await openAppOnPlatformSingleDevice(platform, testInfo, IOS_PRO_CONTEXT);
         const alice = await newUser(device, USERNAME.ALICE);
         return { device, alice };
       });

run/test/specs/user_actions_animated_profile_picture.spec.ts

@@ -13,7 +13,7 @@ import {
   UserSettings,
 } from '../locators/settings';
 import { open_Alice1_Bob1_friends } from '../state_builder';
-import { IOSTestContext } from '../utils/capabilities_ios';
+import { IOS_PRO_CONTEXT } from '../utils/capabilities_ios';
 import { newUser } from '../utils/create_account';
 import { makeAccountPro } from '../utils/mock_pro';
 import { closeApp, openAppOnPlatformSingleDevice, SupportedPlatformsType } from '../utils/open_app';
@@ -63,11 +63,8 @@ bothPlatformsIt({
 });
 
 async function nonProAnimatedDP(platform: SupportedPlatformsType, testInfo: TestInfo) {
-  const iosContext: IOSTestContext = {
-    sessionProEnabled: 'true',
-  };
   const { device } = await test.step(TestSteps.SETUP.NEW_USER, async () => {
-    const { device } = await openAppOnPlatformSingleDevice(platform, testInfo, iosContext);
+    const { device } = await openAppOnPlatformSingleDevice(platform, testInfo, IOS_PRO_CONTEXT);
     await newUser(device, USERNAME.ALICE, { saveUserData: false });
     return { device };
   });
@@ -81,11 +78,8 @@ async function nonProAnimatedDP(platform: SupportedPlatformsType, testInfo: Test
   });
 }
 async function proActivatedCTA(platform: SupportedPlatformsType, testInfo: TestInfo) {
-  const iosContext: IOSTestContext = {
-    sessionProEnabled: 'true',
-  };
   const { device, alice } = await test.step(TestSteps.SETUP.NEW_USER, async () => {
-    const { device } = await openAppOnPlatformSingleDevice(platform, testInfo, iosContext);
+    const { device } = await openAppOnPlatformSingleDevice(platform, testInfo, IOS_PRO_CONTEXT);
     const alice = await newUser(device, USERNAME.ALICE);
     return { device, alice };
   });
@@ -104,11 +98,8 @@ async function proActivatedCTA(platform: SupportedPlatformsType, testInfo: TestI
 }
 
 async function proAnimatedDP(platform: SupportedPlatformsType, testInfo: TestInfo) {
-  const iosContext: IOSTestContext = {
-    sessionProEnabled: 'true',
-  };
   const { device, alice } = await test.step(TestSteps.SETUP.NEW_USER, async () => {
-    const { device } = await openAppOnPlatformSingleDevice(platform, testInfo, iosContext);
+    const { device } = await openAppOnPlatformSingleDevice(platform, testInfo, IOS_PRO_CONTEXT);
     const alice = await newUser(device, USERNAME.ALICE);
     return { device, alice };
   });
@@ -126,15 +117,12 @@ async function proAnimatedDP(platform: SupportedPlatformsType, testInfo: TestInf
 }
 
 async function proAnimatedDPShows(platform: SupportedPlatformsType, testInfo: TestInfo) {
-  const iosContext: IOSTestContext = {
-    sessionProEnabled: 'true',
-  };
   const { devices, prebuilt } = await test.step(TestSteps.SETUP.QA_SEEDER, async () => {
     return await open_Alice1_Bob1_friends({
       platform,
       focusFriendsConvo: false,
       testInfo,
-      iOSContext: iosContext,
+      iOSContext: IOS_PRO_CONTEXT,
     });
   });
   const { alice1, bob1 } = devices;

run/test/specs/user_actions_pin_unpin.spec.ts

@@ -5,7 +5,7 @@ import { communities } from '../../constants/community';
 import { TestSteps } from '../../types/allure';
 import { bothPlatformsIt } from '../../types/sessionIt';
 import { ConversationPinnedIcon, PlusButton } from '../locators/home';
-import { IOSTestContext } from '../utils/capabilities_ios';
+import { IOS_PRO_CONTEXT } from '../utils/capabilities_ios';
 import { joinCommunities } from '../utils/community';
 import { assertPinOrder, getConversationOrder } from '../utils/conversation_order';
 import { newUser } from '../utils/create_account';
@@ -95,12 +95,9 @@ async function pinConversation(platform: SupportedPlatformsType, testInfo: TestI
 }
 
 async function nonProPinnedLimit(platform: SupportedPlatformsType, testInfo: TestInfo) {
-  const iosContext: IOSTestContext = {
-    sessionProEnabled: 'true',
-  };
   const numCommunities = 6;
   const { device } = await test.step(TestSteps.SETUP.NEW_USER, async () => {
-    const { device } = await openAppOnPlatformSingleDevice(platform, testInfo, iosContext);
+    const { device } = await openAppOnPlatformSingleDevice(platform, testInfo, IOS_PRO_CONTEXT);
     await newUser(device, USERNAME.ALICE, { saveUserData: false });
     return { device };
   });
@@ -131,12 +128,9 @@ async function nonProPinnedLimit(platform: SupportedPlatformsType, testInfo: Tes
 }
 
 async function proPinnedLimit(platform: SupportedPlatformsType, testInfo: TestInfo) {
-  const iosContext: IOSTestContext = {
-    sessionProEnabled: 'true',
-  };
   const numCommunities = 6;
   const { device, alice } = await test.step(TestSteps.SETUP.NEW_USER, async () => {
-    const { device } = await openAppOnPlatformSingleDevice(platform, testInfo, iosContext);
+    const { device } = await openAppOnPlatformSingleDevice(platform, testInfo, IOS_PRO_CONTEXT);
     const alice = await newUser(device, USERNAME.ALICE);
     return { device, alice };
   });

run/test/utils/capabilities_ios.ts

@@ -12,6 +12,8 @@ export type IOSTestContext = {
   sessionProEnabled?: string;
 };
 
+export const IOS_PRO_CONTEXT: IOSTestContext = { sessionProEnabled: 'true' };
+
 const iosPathPrefix = process.env.IOS_APP_PATH_PREFIX;
 
 export const iOSBundleId = 'com.loki-project.loki-messenger';