fix: enforce static builds for libsession-util-nodejs

Author: Bilb

.github/workflows/build-binaries.yml

@@ -167,7 +167,7 @@ jobs:
         if: ${{ matrix.is_qa == true }}
         uses: ./actions/sed_for_qa
 
-      - name: Custom build for QA if needed
+      - name: Enforce static builds for libsession-util-nodejs
         uses: ./actions/enforce_static_builds
 
       - name: Build
@@ -342,6 +342,9 @@ jobs:
         with:
           cache_suffix: ${{ matrix.cache_suffix }}
 
+      - name: Enforce static builds for libsession-util-nodejs
+        uses: ./actions/enforce_static_builds
+
       - name: Build
         run: pnpm run build
 

actions/enforce_static_builds/action.yml

@@ -13,7 +13,7 @@ runs:
         fi
 
         if ! find . -name 'libsession_util_nodejs.node' | grep -q .; then
-            echo -e "\n\n\n\n\e[31;1mNo libsession_util_nodejs.node file found\e[0m\n\n\n"
+            echo -e "\nNo libsession_util_nodejs.node file found\n"
             exit 1
         fi
 
@@ -27,22 +27,23 @@ runs:
         while IFS= read -r node_file; do
             if [ "$RUNNER_OS" == "macOS" ]; then
                 if otool -L "$node_file" | \
-                    grep -Ev '^.*\.node:|^\t(/usr/lib/lib(System\.|c\+\+|objc))|/System/Library/Frameworks/(CoreFoundation|NetworkExtension|Foundation|Network)\.framework'; then
+                    grep -Ev '^.*@rpath/libsession_util_nodejs\.node:?|^[^@\t].*\.node:|^[[:space:]]*$|^\t(/usr/lib/lib(System\.|c\+\+|objc))|/System/Library/Frameworks/(CoreFoundation|NetworkExtension|Foundation|Network)\.framework'; then
                     bad=1
                 fi
             elif [ "$RUNNER_OS" == "Linux" ]; then
-                if ldd "$node_file" | grep -Ev '(linux-vdso|ld-linux-(x86-64|armhf|aarch64)|lib(pthread|dl|rt|stdc\+\+|gcc_s|c|m))\.so'; then
+                ldd "$node_file" | grep -Ev '(linux-vdso|ld-linux-(x86-64|armhf|aarch64)|lib(pthread|dl|rt|stdc\+\+|gcc_s|c|m))\.so'
+                if ldd "$node_file" | grep -Ev '^.*\.node:|^[[:space:]]*$|(linux-vdso|ld-linux-(x86-64|armhf|aarch64)|lib(pthread|dl|rt|stdc\+\+|gcc_s|c|m))\.so'; then
                     bad=1
                 fi
             else
-                echo -e "\n\n\n\n\e[31;1mDon't know how to check linked libs on $RUNNER_OS\e[0m\n\n\n"
+                echo -e "\nDon't know how to check linked libs on $RUNNER_OS\n"
                 exit 1
             fi
         done < <(find . -name 'libsession_util_nodejs.node')
 
         if [ -n "$bad" ]; then
-            echo -e "\n\n\n\n\e[31;1mlibsession-util-nodejs links to unexpected libraries\e[0m\n\n\n"
+            echo -e "\nlibsession-util-nodejs links to unexpected libraries\n"
             exit 1
         fi
 
-        echo -e "\n\n\n\n\e[32;1mNo unexpected linked libraries found\e[0m\n\n\n"
+        echo -e "\nNo unexpected linked libraries found\n"