Merge pull request #1929 from session-foundation/fix-caret-performance-issue

fix: remove caret animation causing perf issue

Author: Bilb

stylesheets/_session.scss

@@ -21,22 +21,10 @@
   word-break: break-all;
 }
 
-@keyframes blink-caret {
-  0%,
-  100% {
-    caret-color: transparent;
-  }
-  50% {
-    caret-color: var(--text-primary-color);
-  }
-}
-
 input,
 textarea,
 div[role='textbox'] {
   caret-color: var(--text-primary-color);
-  animation: blink-caret infinite linear alternate 0.75s;
-  caret-animation: manual;
 }
 
 * {

ts/components/leftpane/LeftPaneMessageSection.tsx

@@ -23,7 +23,10 @@ import { OverlayMessage } from './overlay/OverlayMessage';
 import { OverlayMessageRequest } from './overlay/OverlayMessageRequest';
 import { OverlayChooseAction } from './overlay/choose-action/OverlayChooseAction';
 import { sectionActions } from '../../state/ducks/section';
-import { openConversationWithMessages } from '../../state/ducks/conversations';
+import {
+  openConversationWithMessages,
+  resetConversationExternal,
+} from '../../state/ducks/conversations';
 import { useKeyboardShortcut } from '../../hooks/useKeyboardShortcut';
 import { KbdShortcut } from '../../util/keyboardShortcuts';
 import { UserUtils } from '../../session/utils';
@@ -99,7 +102,15 @@ function useConversationListKeyboardShortcuts(conversationIds: Array<string>) {
     void openConversationWithMessages({ conversationKey: id, messageId: null });
   };
 
+  const closeOpenConversation = () => {
+    window.inboxStore?.dispatch(resetConversationExternal());
+  };
+
   useKeyboardShortcut({ shortcut: KbdShortcut.openNoteToSelf, handler: openNoteToSelf });
+  useKeyboardShortcut({
+    shortcut: KbdShortcut.closeOpenConversation,
+    handler: closeOpenConversation,
+  });
   useKeyboardShortcut({
     shortcut: KbdShortcut.conversationNavigation1,
     handler: () => void openConversation(conversationIds[0]),

ts/util/keyboardShortcuts.ts

@@ -86,6 +86,13 @@ const conversationNavigation = Object.fromEntries(
 // in the database and its an often overlooked feature with little lift and massive UX gains.
 export const KbdShortcut = {
   ...conversationNavigation,
+  closeOpenConversation: {
+    name: 'Close Open Conversation',
+    scope: 'global',
+    withCtrl: true,
+    keys: ['w'],
+  },
+
   keyboardShortcutModal: {
     name: 'Keyboard Shortcuts',
     scope: 'global',
@@ -206,6 +213,7 @@ export const KbdShortcutInformation: Record<string, Array<KbdShortcutOptions>> =
     KbdShortcut.createGroup,
     KbdShortcut.joinCommunity,
     KbdShortcut.openNoteToSelf,
+    KbdShortcut.closeOpenConversation,
     KbdShortcut.conversationListSearch,
     KbdShortcut.keyboardShortcutModal,
     baseConversationNavigation,