fix: address PR comments

Author: Bilb

stylesheets/_rtl.scss

@@ -1,5 +1,6 @@
 body.rtl {
   input,
+  button,
   textarea,
   .module-left-pane,
   .module-conversation-list-item,

ts/components/buttons/PanelRadioButton.tsx

@@ -57,7 +57,7 @@ export const PanelRadioButton = (props: PanelRadioButtonProps) => {
             label=""
             disabled={disabled}
             inputDataTestId={radioInputDataTestId}
-            style={{ paddingRight: 'var(--margins-xs)' }}
+            style={{ paddingInlineEnd: 'var(--margins-xs)' }}
           />
         </StyledCheckContainer>
       </StyledContent>

ts/components/buttons/PlusAvatarButton.tsx

@@ -1,6 +1,5 @@
 import type { SessionDataTestId } from 'react';
 import { SessionIconButton } from '../icon';
-import { useIsRtl } from '../../util/i18n/rtlSupport';
 
 export const PlusAvatarButton = ({
   onClick,
@@ -9,8 +8,6 @@ export const PlusAvatarButton = ({
   onClick?: () => void;
   dataTestId?: SessionDataTestId;
 }) => {
-  const isRtl = useIsRtl();
-
   return (
     <SessionIconButton
       iconType="plusFat"
@@ -25,8 +22,7 @@ export const PlusAvatarButton = ({
       style={{
         position: 'absolute',
         bottom: 0,
-        right: isRtl ? undefined : 0,
-        left: isRtl ? 0 : undefined,
+        insetInlineEnd: 0,
       }}
     />
   );

ts/components/inputs/ClearInputButton.tsx

@@ -1,5 +1,4 @@
 import type { SessionDataTestId } from 'react';
-import { useHTMLDirection } from '../../util/i18n/rtlSupport';
 import { SessionIconButton } from '../icon';
 import { alignButtonEndAbsoluteButtonStyle } from './sharedStyles';
 
@@ -12,8 +11,7 @@ export const ClearInputButton = ({
   dataTestId: SessionDataTestId;
   show: boolean;
 }) => {
-  const htmlDirection = useHTMLDirection();
-  const style = alignButtonEndAbsoluteButtonStyle(htmlDirection);
+  const style = alignButtonEndAbsoluteButtonStyle();
 
   if (!show) {
     return null;

ts/components/inputs/ShowHidePasswordButton.tsx

@@ -1,5 +1,4 @@
 import type { SessionDataTestId } from 'react';
-import { useHTMLDirection } from '../../util/i18n/rtlSupport';
 import { alignButtonEndAbsoluteButtonStyle } from './sharedStyles';
 import { SessionIconButton } from '../icon';
 
@@ -15,8 +14,7 @@ type ShowHideButtonProps = {
 export const ShowHideButton = (props: ShowHideButtonProps) => {
   const { forceShow, toggleForceShow, hasError, ariaLabels, dataTestIds } = props;
 
-  const htmlDirection = useHTMLDirection();
-  const style = alignButtonEndAbsoluteButtonStyle(htmlDirection);
+  const style = alignButtonEndAbsoluteButtonStyle();
 
   return (
     <SessionIconButton

ts/components/inputs/sharedStyles.tsx

@@ -1,12 +1,10 @@
 import type { CSSProperties } from 'styled-components';
-import type { HTMLDirection } from '../../util/i18n/rtlSupport';
 
-export function alignButtonEndAbsoluteButtonStyle(htmlDirection: HTMLDirection): CSSProperties {
+export function alignButtonEndAbsoluteButtonStyle(): CSSProperties {
   return {
     position: 'absolute',
     top: '50%',
     transform: 'translateY(-50%)',
-    left: htmlDirection === 'ltr' ? undefined : 'var(--margins-sm)',
-    right: htmlDirection === 'ltr' ? 'var(--margins-sm)' : undefined,
+    insetInlineEnd: 'var(--margins-sm)',
   };
 }

ts/components/menuAndSettingsHooks/useCopyAccountId.ts

@@ -11,7 +11,7 @@ function useShowCopyAccountId(conversationId?: string) {
 export function useShowCopyAccountIdCb(conversationId?: string) {
   const canCopy = useShowCopyAccountId(conversationId);
 
-  if (!canCopy && conversationId) {
+  if (!canCopy || !conversationId) {
     return null;
   }
 

ts/components/menuAndSettingsHooks/useGroupCommonNoShow.tsx

@@ -1,7 +1,7 @@
 import { useIsActive, useIsBlocked, useIsKickedFromGroup } from '../../hooks/useParamSelector';
 
 export function useGroupCommonNoShow(convoId: string) {
-  const isKickedFromGroup = useIsKickedFromGroup(convoId) || false;
+  const isKickedFromGroup = useIsKickedFromGroup(convoId);
   const isBlocked = useIsBlocked(convoId);
   const isActive = useIsActive(convoId);
 

ts/components/menuAndSettingsHooks/useShowBlockUnblock.ts

@@ -16,7 +16,8 @@ export function useShowBlockUnblock(convoId?: string) {
   const isIncomingRequest = useIsIncomingRequest(convoId);
   const dispatch = useDispatch();
 
-  const showBlockUnblock = convoId && !isMe && isPrivate && !isIncomingRequest && !PubKey.isBlinded(convoId);
+  const showBlockUnblock =
+    convoId && !isMe && isPrivate && !isIncomingRequest && !PubKey.isBlinded(convoId);
 
   if (!showBlockUnblock) {
     return null;

ts/components/menuAndSettingsHooks/useShowLeaveGroup.ts

@@ -12,7 +12,7 @@ import { useIsMessageRequestOverlayShown } from '../../state/selectors/section';
 
 export function useShowLeaveGroupCb(conversationId?: string) {
   const isClosedGroup = useIsClosedGroup(conversationId);
-  const isKickedFromGroup = useIsKickedFromGroup(conversationId) || false;
+  const isKickedFromGroup = useIsKickedFromGroup(conversationId);
   const isGroupDestroyed = useIsGroupDestroyed(conversationId);
   const isMessageRequestShown = useIsMessageRequestOverlayShown();
   const username = useConversationUsername(conversationId) || conversationId;