fix: allow 0 as avatarProfileTs to be applied

for the transition where not eveyrone has upgraded

Author: Bilb

ts/models/conversation.ts

@@ -1474,7 +1474,19 @@ export class ConversationModel extends Model<ConversationAttributes> {
     newProfile: SetSessionProfileDetails
   ): newProfile is Extract<T, { profileUpdatedAtSeconds: number }> {
     if (isSetProfileWithUpdatedAtSeconds(newProfile)) {
+      // For the transition period, we need to allow an incoming profile to be applied when
+      // the timestamp is not set (defaults to 0).
+      if (newProfile.profileUpdatedAtSeconds === 0 && this.getProfileUpdatedSeconds() === 0) {
+        window.log.debug(
+          `shouldApplyPrivateProfileUpdate for ${ed25519Str(this.id)} incomingSeconds:0 currentSeconds:0. Allowing overwrite`
+        );
+        return true;
+      }
       const ts = new Timestamp({ value: newProfile.profileUpdatedAtSeconds });
+      window.log.debug(
+        `shouldApplyPrivateProfileUpdate for ${ed25519Str(this.id)} incomingSeconds:${ts.seconds()} currentSeconds:${this.getProfileUpdatedSeconds()} -> ${this.getProfileUpdatedSeconds() < ts.seconds()}`
+      );
+
       return this.getProfileUpdatedSeconds() < ts.seconds();
     }
     // for non private setProfile calls, we do not need to check the updatedAtSeconds

ts/models/conversationAttributes.ts

@@ -233,6 +233,10 @@ export type WithAvatarPointer = {
 };
 
 export type WithProfileUpdatedAtSeconds = {
+  /**
+   * 0 is allowed for the transition period (until enough users have migrated to sending their profileUpdatedAtSeconds).
+   * Allowed as in an incoming message with a lokiProfile updated at 0, will be applied locally, if needed
+   */
   profileUpdatedAtSeconds: number;
 };