chore: cleanup after big localise changes

Author: Bilb

ts/components/calling/IncomingCallDialog.tsx

@@ -84,19 +84,19 @@ export const IncomingCallDialog = () => {
       <SessionWrapperModal
         headerChildren={
           <ModalBasicHeader
-            title={tr('callsIncoming', { name: from ?? tr('unknown').toString() })}
+            title={tr('callsIncoming', { name: from ?? tr('unknown') })}
           />
         }
         buttonChildren={
           <ModalActionsContainer>
             <SessionButton
-              text={tr('accept').toString()}
+              text={tr('accept')}
               buttonType={SessionButtonType.Simple}
               onClick={handleAcceptIncomingCall}
               buttonColor={SessionButtonColor.Danger}
             />
             <SessionButton
-              text={tr('decline').toString()}
+              text={tr('decline')}
               buttonType={SessionButtonType.Simple}
               onClick={handleDeclineIncomingCall}
             />

ts/components/conversation/ContactName.tsx

@@ -69,7 +69,7 @@ export const ContactName = (props: Props) => {
       {shouldShowProfile ? (
         <div style={styles} className={`${prefix}__profile-name`}>
           <Emojify
-            text={isYou ? tr('you').toString() : displayedName}
+            text={isYou ? tr('you') : displayedName}
             sizeClass="small"
             isGroup={!isPrivate}
           />

ts/components/conversation/message/message-item/notification-bubble/CallNotification.tsx

@@ -4,7 +4,7 @@ import { useSelectedNicknameOrProfileNameOrShortenedPubkey } from '../../../../.
 import { ExpirableReadableMessage } from '../ExpirableReadableMessage';
 import { NotificationBubble } from './NotificationBubble';
 import { Localizer } from '../../../../basic/Localizer';
-import { MergedLocalizerTokens, tr } from '../../../../../localization/localeTools';
+import { MergedLocalizerTokens } from '../../../../../localization/localeTools';
 import type { WithMessageId } from '../../../../../session/types/with';
 import { useMessageCallNotificationType } from '../../../../../state/selectors';
 import { LUCIDE_ICONS_UNICODE } from '../../../../icon/lucide';
@@ -37,7 +37,7 @@ export const CallNotification = (props: WithMessageId) => {
 
   const notificationType = useMessageCallNotificationType(messageId);
 
-  const name = useSelectedNicknameOrProfileNameOrShortenedPubkey() ?? tr('unknown');
+  const name = useSelectedNicknameOrProfileNameOrShortenedPubkey();
 
   if (!notificationType) {
     return null;

ts/components/dialog/UpdateGroupNameDialog.tsx

@@ -154,7 +154,7 @@ export function UpdateGroupNameDialog(props: { conversationId: string }) {
             disabled={isNameChangePending || !newGroupName || !newGroupName.trim()}
           />
           <SessionButton
-            text={tr('cancel').toString()}
+            text={tr('cancel')}
             buttonColor={SessionButtonColor.Danger}
             buttonType={SessionButtonType.Simple}
             onClick={closeDialog}

ts/components/leftpane/overlay/OverlayClosedGroup.tsx

@@ -30,7 +30,7 @@ import { searchActions } from '../../../state/ducks/search';
 import { useContactsToInviteTo } from '../../../hooks/useContactsToInviteToGroup';
 import { NoContacts, NoResultsForSearch } from '../../search/NoResults';
 import { SimpleSessionTextarea } from '../../inputs/SessionInput';
-import { tr } from '../../../localization/localeTools';
+import { tr, tStripped } from '../../../localization/localeTools';
 
 const StyledGroupMemberListContainer = styled.div`
   display: flex;
@@ -94,12 +94,12 @@ export const OverlayClosedGroupV2 = () => {
     if (selectedMemberIds.length < 1) {
       ToastUtils.pushToastError(
         'pickClosedGroupMember',
-        tr('groupCreateErrorNoMembers').toString()
+        tr('groupCreateErrorNoMembers')
       );
       return;
     }
     if (selectedMemberIds.length >= VALIDATION.CLOSED_GROUP_SIZE_LIMIT) {
-      ToastUtils.pushToastError('closedGroupMaxSize', tr('groupAddMemberMaximum'));
+      ToastUtils.pushToastError('closedGroupMaxSize', tStripped('groupAddMemberMaximum'));
       return;
     }
     // trigger the add through redux.

ts/components/settings/section/CategoryRecoveryPassword.tsx

@@ -178,7 +178,7 @@ export const SettingsCategoryRecoveryPassword = () => {
           onClick={() => {
             dispatch(updateHideRecoveryPasswordModal({ state: 'firstWarning' }));
           }}
-          buttonText={tr('hide').toString()}
+          buttonText={tr('hide')}
           buttonColor={SessionButtonColor.Danger}
           dataTestId={'hide-recovery-password-button'}
         />

ts/interactions/conversationInteractions.ts

@@ -396,7 +396,7 @@ export async function showLeaveGroupByConvoId(conversationId: string, name: stri
   window?.inboxStore?.dispatch(
     updateConfirmModal({
       title: tr('groupLeave'),
-      i18nMessage: { token: 'groupLeaveDescription', args: { group_name: name ?? '' } },
+      i18nMessage: { token: 'groupLeaveDescription', args: { group_name: name ?? tr('unknown') } },
       onClickOk,
       okText: tr('leave'),
       okTheme: SessionButtonColor.Danger,
@@ -441,7 +441,7 @@ export async function showDeleteGroupByConvoId(conversationId: string, name: str
       title: tr('groupDelete'),
       i18nMessage: {
         token: weAreAdmin ? 'groupDeleteDescription' : 'groupDeleteDescriptionMember',
-        args: { group_name: name ?? '' },
+        args: { group_name: name ?? tr('unknown') },
       },
       onClickOk,
       okText: tr('delete'),

ts/state/ducks/releasedFeatures.tsx

@@ -48,7 +48,7 @@ const releasedFeaturesSlice = createSlice({
 
       // state.sesh101NotificationAt = handleReleaseNotification({
       //   featureName: 'useSESH101',
-      //   message: tr('sessionNetworkNotificationLive').toString(),
+      //   message: tr('sessionNetworkNotificationLive'),
       //   lastRefreshedAt: state.refreshedAt,
       //   notifyAt: state.sesh101NotificationAt,
       //   delayMs: 1 * DURATION.HOURS,