fix: test and validate profile info override works

Author: Bilb

ts/models/conversation.ts

@@ -1470,7 +1470,9 @@ export class ConversationModel extends Model<ConversationAttributes> {
     }
   }
 
-  private shouldApplyPrivateProfileUpdate(newProfile: SetSessionProfileDetails) {
+  private shouldApplyPrivateProfileUpdate<T extends SetSessionProfileDetails>(
+    newProfile: SetSessionProfileDetails
+  ): newProfile is Extract<T, { profileUpdatedAtSeconds: number }> {
     if (isSetProfileWithUpdatedAtSeconds(newProfile)) {
       const ts = new Timestamp({ value: newProfile.profileUpdatedAtSeconds });
       return this.getProfileUpdatedSeconds() < ts.seconds();
@@ -1500,6 +1502,10 @@ export class ConversationModel extends Model<ConversationAttributes> {
       this.set({
         displayNameInProfile: newProfile.displayName,
       });
+      // name has changed, also apply the new profileUpdatedAtSeconds timestamp
+      if (isSetProfileWithUpdatedAtSeconds(newProfile)) {
+        this.set({ profileUpdatedSeconds: newProfile.profileUpdatedAtSeconds });
+      }
       nameChanged = true;
     }
     const type = newProfile.type;
@@ -1533,9 +1539,13 @@ export class ConversationModel extends Model<ConversationAttributes> {
               fallbackAvatarInProfile: undefined,
             });
             avatarChanged = true;
+            // avatar has changed, also apply the new profileUpdatedAtSeconds timestamp
+            if (isSetProfileWithUpdatedAtSeconds(newProfile)) {
+              this.set({ profileUpdatedSeconds: newProfile.profileUpdatedAtSeconds });
+            }
           }
         }
-        if (avatarChanged) {
+        if (avatarChanged || nameChanged) {
           await this.commit();
         }
         return { nameChanged, avatarNeedsDownload: false, avatarChanged };
@@ -1562,6 +1572,10 @@ export class ConversationModel extends Model<ConversationAttributes> {
         }
         this.set({ avatarPointer: newProfile.avatarPointer, profileKey: newProfileKeyHex });
 
+        // avatar has changed, also apply the new profileUpdatedAtSeconds timestamp
+        if (isSetProfileWithUpdatedAtSeconds(newProfile)) {
+          this.set({ profileUpdatedSeconds: newProfile.profileUpdatedAtSeconds });
+        }
         await this.commit();
 
         return { nameChanged, avatarNeedsDownload: hasAvatarInNewProfile, avatarChanged: true };
@@ -1591,6 +1605,9 @@ export class ConversationModel extends Model<ConversationAttributes> {
           return { nameChanged, avatarChanged: false, avatarNeedsDownload: false };
         }
 
+        // avatar has changed, but we are only dealing with the downloaded part of it here
+        // so this actually is not a profile update change. Nothing to do, as the newProfile type suggests
+
         this.set({
           avatarPointer: newProfile.avatarPointer,
           avatarInProfile: newProfile.avatarPath,

ts/session/utils/libsession/libsession_utils.ts

@@ -624,14 +624,16 @@ async function createMemberAndSetDetails({
   profileUpdatedSeconds: number;
 }) {
   await MetaGroupWrapperActions.memberConstructAndSet(groupPk, memberPubkey);
-  await MetaGroupWrapperActions.memberSetProfileDetails(groupPk, memberPubkey, {
+  const details = {
     name: displayName ?? '',
     profilePicture:
       profileKeyHex && avatarUrl
         ? { url: avatarUrl, key: from_hex(profileKeyHex) }
         : { url: '', key: new Uint8Array() },
     profileUpdatedSeconds,
-  });
+  };
+
+  await MetaGroupWrapperActions.memberSetProfileDetails(groupPk, memberPubkey, details);
 }
 
 export const LibSessionUtil = {

ts/state/ducks/metaGroups.ts

@@ -172,7 +172,6 @@ const initNewGroupInWrapper = createAsyncThunk(
         const member = uniqMembers[index];
         const memberProfileDetails = ConvoHub.use().get(member).getPrivateProfileDetails() || null;
         const profilePic = memberProfileDetails?.toHexProfilePicture() || null;
-        debugger;
 
         // we just create the members in the state. Their invite state defaults to NOT_SENT,
         // which will make our logic kick in to send them an invite in the `GroupInviteJob`

ts/util/accountManager.ts

@@ -24,6 +24,7 @@ import { PromiseUtils } from '../session/utils';
 import { SnodeAPI } from '../session/apis/snode_api/SNodeAPI';
 import { tr } from '../localization/localeTools';
 import { NetworkTime } from './NetworkTime';
+import { UserConfigWrapperActions } from '../webworker/workers/browser/libsession_worker_interface';
 
 /**
  * Might throw
@@ -227,6 +228,8 @@ export async function registrationDone(ourPubkey: string, displayName: string) {
     ourPubkey,
     ConversationTypeEnum.PRIVATE
   );
+  await UserConfigWrapperActions.setNameTruncated(displayName ?? 'Anonymous');
+
   await conversation.setSessionProfile({
     type: 'displayNameChangeOnlyPrivate',
     displayName,