Skip to content

Commit a253ab0

Browse files
authored
Merge pull request #1556 from session-foundation/chore/update_contributor_windows_instructions
chore: update windows contributor instructions
2 parents 9006358 + 0f63b25 commit a253ab0

File tree

2 files changed

+13
-2
lines changed

2 files changed

+13
-2
lines changed

CONTRIBUTING.md

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -161,6 +161,11 @@ The following instructions will install the following:
161161

162162
Setup instructions for Windows using Chocolatey:
163163

164+
> [!WARNING]
165+
> These setup instructions assume a clean system with none of these applications installed.
166+
> If your machine is already partially set up you may be better off manually installing
167+
> what you're missing.
168+
164169
- Open PowerShell as Administrator
165170

166171
- Install [Chocolatey](https://docs.chocolatey.org/en-us/choco/setup#installing-chocolatey-cli)
@@ -180,6 +185,9 @@ Setup instructions for Windows using Chocolatey:
180185
choco install git
181186
```
182187

188+
> [!WARNING]
189+
> You may need to restart PowerShell for git to be recognized.
190+
183191
After installing Git, you may need to disable `core.autocrlf` to prevent line ending issues.
184192

185193
```sh
@@ -202,7 +210,7 @@ Setup instructions for Windows using Chocolatey:
202210

203211
> [!WARNING]
204212
> This next step will likely take a long time.
205-
> Make sure to restart your computer once it is finished.
213+
> You may need to restart PowerShell for c++ build tools to be recognized.
206214
207215
- Install [Visual C++ build tools workload for Visual Studio 2022](https://community.chocolatey.org/packages/visualstudio2022-workload-vctools)
208216

@@ -230,6 +238,9 @@ Setup instructions for Windows using Chocolatey:
230238
choco install python --version <version>
231239
```
232240

241+
> [!WARNING]
242+
> You may need to restart PowerShell for python to be recognized.
243+
233244
- Install [setuptools](https://pypi.org/project/setuptools/)
234245

235246
```sh

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ grep .dmg signature.asc
9494
<details>
9595
<summary>Windows</summary>
9696

97-
**Powershell**
97+
**PowerShell**
9898

9999
```PowerShell
100100
Get-FileHash -Algorithm SHA256 session-desktop-win-x64-$SESSION_VERSION.exe # checksum is uppercase but should otherwise match

0 commit comments

Comments
 (0)