Merge pull request #1577 from session-foundation/fix-show-author-last-message-group

fix: show author of last message in leftpane for groups

Author: Bilb

ts/components/leftpane/ActionsPanel.tsx

@@ -164,6 +164,8 @@ const doAppStartUp = async () => {
     // Schedule all avatarMigrateJobs in some time to let anything incoming from the network be handled first
     void AvatarMigrate.scheduleAllAvatarMigrateJobs();
   }, 1 * DURATION.MINUTES);
+
+  void regenerateLastMessagesGroupsCommunities();
 };
 
 function useUpdateBadgeCount() {
@@ -195,6 +197,24 @@ function useDebugThemeSwitch() {
   );
 }
 
+/**
+ * We only need to regenerate the last message of groups/communities once,
+ * and we can remove it in a few months safely
+ */
+async function regenerateLastMessagesGroupsCommunities() {
+  if (Storage.getBoolOr(SettingsKey.lastMessageGroupsRegenerated, false)) {
+    return; // already regenerated once
+  }
+
+  ConvoHub.use()
+    .getConversations()
+    .filter(m => m.isClosedGroupV2() || m.isPublic())
+    .forEach(m => {
+      m.updateLastMessage();
+    });
+  await Storage.put(SettingsKey.lastMessageGroupsRegenerated, true);
+}
+
 /**
  * ActionsPanel is the far left banner (not the left pane).
  * The panel with buttons to switch between the message/contact/settings/theme views

ts/data/settings-key.ts

@@ -22,6 +22,14 @@ const latestUserGroupEnvelopeTimestamp = 'latestUserGroupEnvelopeTimestamp';
 const latestUserContactsEnvelopeTimestamp = 'latestUserContactsEnvelopeTimestamp';
 const showOnboardingAccountJustCreated = 'showOnboardingAccountJustCreated';
 
+/**
+ * When we added the author of a message in groups in the last message,
+ * we also had to regenerate the existing last messages.
+ * We only need to do this once, and we can remove it in a few months safely :tm:
+ *
+ */
+const lastMessageGroupsRegenerated = 'lastMessageGroupsRegenerated';
+
 export const SettingsKey = {
   settingsReadReceipt,
   settingsTypingIndicator,
@@ -44,6 +52,7 @@ export const SettingsKey = {
   hasFollowSystemThemeEnabled,
   hideRecoveryPassword,
   showOnboardingAccountJustCreated,
+  lastMessageGroupsRegenerated,
 } as const;
 
 export const KNOWN_BLINDED_KEYS_ITEM = 'KNOWN_BLINDED_KEYS_ITEM';

ts/models/message.ts

@@ -407,6 +407,14 @@ export class MessageModel extends Model<MessageAttributes> {
           );
         }
       });
+      if (this.getConversation()?.isOpenGroupV2() || this.getConversation()?.isClosedGroupV2()) {
+        const source = this.get('source');
+
+        const author = isUsAnySogsFromCache(source)
+          ? tr('you')
+          : ConvoHub.use().getNicknameOrRealUsernameOrPlaceholder(source);
+        return tr('messageSnippetGroup', { author, message_snippet: bodyMentionsMappedToNames });
+      }
       return bodyMentionsMappedToNames;
     }