fix: address PR comments

Author: Bilb

ts/components/dialog/UpdateGroupMembersDialog.tsx

@@ -52,7 +52,7 @@ function useSortedListOfMembers(convoId: string) {
   const groupAdmins = useGroupAdmins(convoId);
 
   const sortedMembersNon03 = useMemo(
-    () => [...groupMembersLegacy].sort(m => (groupAdmins?.includes(m) ? -1 : 0)),
+    () => groupMembersLegacy.toSorted(m => (groupAdmins?.includes(m) ? -1 : 0)),
     [groupMembersLegacy, groupAdmins]
   );
   const sortedMembers = isV2Group ? groupMembers03Group.map(m => m.pubkeyHex) : sortedMembersNon03;

ts/components/inputs/SessionInput.tsx

@@ -503,6 +503,7 @@ export const SimpleSessionTextarea = (
               }
               if (e.key === 'Enter') {
                 e.preventDefault();
+                e.stopPropagation();
                 props?.onEnterPressed();
               }
             }}

ts/components/leftpane/overlay/OverlayClosedGroup.tsx

@@ -71,7 +71,7 @@ export const OverlayClosedGroupV2 = () => {
     dispatch(groupInfoActions.updateGroupCreationName({ name: value }));
   }
 
-  async function onEnterPressed() {
+  function onEnterPressed() {
     setGroupNameError(undefined);
     if (isCreatingGroup) {
       window?.log?.warn('Closed group creation already in progress');
@@ -140,7 +140,6 @@ export const OverlayClosedGroupV2 = () => {
           value={groupName}
           onValueChanged={onValueChanged}
           singleLine={true}
-          // eslint-disable-next-line @typescript-eslint/no-misused-promises
           onEnterPressed={onEnterPressed}
           providedError={groupNameError}
           disabled={isCreatingGroup || noContactsForClosedGroup}

ts/state/selectors/selectedConversation.ts

@@ -262,7 +262,7 @@ export function useSelectedIsBlocked() {
 
 export function useSelectedIsApproved() {
   return useSelector((state: StateType): boolean => {
-    return getSelectedConversation(state)?.isApproved || false;
+    return getSelectedConversation(state)?.isApproved ?? false;
   });
 }
 

tsconfig.json

@@ -5,7 +5,7 @@
     "module": "commonjs", // Specify module code generation: 'none', 'commonjs', 'amd', 'system', 'umd', 'es2015', or 'ESNext'.
     "lib": [
       "dom", // Required to access `window`
-      "es2021"
+      "ES2023"
     ],
     "jsx": "react-jsx", // Specify JSX code generation: 'preserve', 'react-native', or 'react-jsx'.
     // "noEmitHelpers": false,