Merge pull request #1511 from giomiglietta/feat-increase-maximum-password-length-256

feat: increased max password length to 256

Author: Bilb

ts/session/constants.ts

@@ -124,7 +124,7 @@ export const PASSWORD_LENGTH = {
    */
   MIN_PASSWORD_LEN: 6,
   /**
-   * 64 chars
+   * 256 chars
    */
-  MAX_PASSWORD_LEN: 64,
+  MAX_PASSWORD_LEN: 256,
 };

ts/test/session/unit/utils/Password_test.ts

@@ -58,12 +58,12 @@ describe('Password Util', () => {
       });
     });
 
-    it('should return an error if password is not between 6 and 64 characters', () => {
-      const invalid = ['a', 'abcde', '#'.repeat(65), '#'.repeat(100)];
+    it('should return an error if password is not between 6 and 256 characters', () => {
+      const invalid = ['a', 'abcde', '#'.repeat(257), '#'.repeat(300)];
       invalid.forEach(pass => {
         assert.strictEqual(
           PasswordUtil.validatePassword(pass),
-          'Password must be between 6 and 64 characters long'
+          'Password must be between 6 and 256 characters long'
         );
       });
     });

ts/util/passwordUtils.ts

@@ -13,20 +13,25 @@ export const generateHash = (phrase: string) => phrase && sha512(phrase);
 export const matchesHash = (phrase: string | null, hash: string) =>
   phrase && sha512(phrase) === hash;
 
+const passwordArgs = {
+  min: PASSWORD_LENGTH.MIN_PASSWORD_LEN.toString(),
+  max: PASSWORD_LENGTH.MAX_PASSWORD_LEN.toString(),
+};
+
 export const validatePassword = (phrase: string) => {
   if (!isString(phrase)) {
     return tr('passwordError');
   }
 
   if (phrase.length === 0) {
-    return tr('passwordErrorLength');
+    return tr('passwordErrorLength', passwordArgs);
   }
 
   if (
     phrase.length < PASSWORD_LENGTH.MIN_PASSWORD_LEN ||
     phrase.length > PASSWORD_LENGTH.MAX_PASSWORD_LEN
   ) {
-    return tr('passwordErrorLength');
+    return tr('passwordErrorLength', passwordArgs);
   }
 
   // Restrict characters to letters, numbers and symbols