Skip to content

Commit 6f8d277

Browse files
committed
chore: make strings for desktop validated too
1 parent 2b6541b commit 6f8d277

File tree

2 files changed

+12
-0
lines changed

2 files changed

+12
-0
lines changed

.github/workflows/check_for_crowdin_updates.yml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -123,6 +123,10 @@ jobs:
123123
"${{ github.workspace }}/raw_translations" \
124124
"${{ github.workspace }}/desktop/_locales" \
125125
"${{ github.workspace }}/desktop/ts/localization/constants.ts"
126+
127+
- name: Validate strings for Desktop
128+
run: cd ${{ github.workspace }}/desktop && npm install -g yarn && yarn build:locales
129+
126130
- name: Upload Desktop artifacts
127131
uses: actions/upload-artifact@v4
128132
with:
@@ -231,6 +235,8 @@ jobs:
231235
- name: Nothing to do
232236
shell: bash
233237
run: echo "Nothing to do here"
238+
exit 1
239+
234240

235241
make_android_pr:
236242
name: Make Android PR

actions/checkout_desktop/action.yml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,12 @@ runs:
99
repository: 'session-foundation/session-desktop'
1010
path: 'desktop'
1111
ref: 'dev'
12+
- uses: actions/setup-node@v4
13+
with:
14+
node-version-file: 'desktop/.nvmrc'
15+
16+
# File containing the version Spec of the version to use. Examples: package.json, .nvmrc, .node-version, .tool-versions.
17+
# If node-version a
1218
- name: Remove existing strings
1319
shell: bash
1420
run: |

0 commit comments

Comments
 (0)