fix: bad inclusion logic on bounds comp idx ub

Author: setavenger

internal/database/dbpebble/encoders.go

@@ -8,6 +8,13 @@ import (
 	"github.com/setavenger/blindbit-lib/logging"
 )
 
+var maxTxid = [SizeTxid]byte{
+	0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF,
+	0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF,
+	0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF,
+	0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF,
+}
+
 // ---------------- Keys ----------------
 
 func KeyBlockTx(blockHash []byte, pos uint32) []byte {
@@ -160,13 +167,16 @@ func KeyComputeIndex(height uint32, txid []byte) []byte {
 	return k
 }
 
+// BoundsComputeIndex creates bounds for compute index keys from startHeight to endHeight (both inclusive)
 func BoundsComputeIndex(startHeight, endHeight uint32) (lb, ub []byte) {
 	lb = make([]byte, 1+SizeHeight+SizeTxid)
 	lb[0] = KComputeIndex
 	be32(startHeight, lb[1:1+SizeHeight])
 	ub = make([]byte, 1+SizeHeight+SizeTxid)
 	ub[0] = KComputeIndex
 	be32(endHeight, ub[1:1+SizeHeight])
+	// Fill txid portion with 0xFF to include all transactions at endHeight
+	copy(ub[1+SizeHeight:], maxTxid[:])
 	return
 }
 
@@ -177,9 +187,7 @@ func BoundsComputeIndexOneHeight(height uint32) (lb, ub []byte) {
 	ub = make([]byte, 1+SizeHeight+SizeTxid)
 	ub[0] = KComputeIndex
 	be32(height, ub[1:1+SizeHeight])
-	for i := 1 + SizeHeight; i < 1+SizeHeight+SizeTxid; i++ {
-		ub[i] = 0xFF
-	}
+	copy(ub[1+SizeHeight:], maxTxid[:])
 	return lb, ub
 }