refactor: vite env vars (#2532)

* refactor: vite env vars

Signed-off-by: Adam Setch <adam.setch@outlook.com>

* refactor: vite env vars

Signed-off-by: Adam Setch <adam.setch@outlook.com>

---------

Signed-off-by: Adam Setch <adam.setch@outlook.com>

Author: setchy

.env.example

@@ -1,2 +1,2 @@
 # Aptabase Key - Analytics
-APTABASE_KEY=some-key
+VITE_APTABASE_KEY=some-key

.github/workflows/build.yml

@@ -38,12 +38,12 @@ jobs:
       - name: Build application
         run: pnpm build
         env:
-          APTABASE_KEY: ${{ secrets.APTABASE_KEY }}
+          VITE_APTABASE_KEY: ${{ secrets.APTABASE_KEY }}
 
       - name: Package for ${{ matrix.platform }}
         run: ${{ matrix.package-cmd }}
         env:
-          APTABASE_KEY: ${{ secrets.APTABASE_KEY }}
+          VITE_APTABASE_KEY: ${{ secrets.APTABASE_KEY }}
           # Signing certificates - important to use the correct cert per platform
           CSC_LINK: ${{ matrix.platform == 'macOS' && secrets.CSC_LINK || (matrix.platform == 'windows' && secrets.WIN_CSC_LINK || '') }}
           CSC_KEY_PASSWORD: ${{ matrix.platform == 'macOS' && secrets.CSC_KEY_PASSWORD || (matrix.platform == 'windows' && secrets.WIN_CSC_KEY_PASSWORD || '') }}

.github/workflows/publish.yml

@@ -67,12 +67,12 @@ jobs:
       - name: Build application
         run: pnpm build
         env:
-          APTABASE_KEY: ${{ secrets.APTABASE_KEY }}
+          VITE_APTABASE_KEY: ${{ secrets.APTABASE_KEY }}
 
       - name: Package and publish for ${{ matrix.platform }}
         run: ${{ matrix.package-cmd }}
         env:
-          APTABASE_KEY: ${{ secrets.APTABASE_KEY }}
+          VITE_APTABASE_KEY: ${{ secrets.APTABASE_KEY }}
           # Signing certificates - important to use the correct cert per platform
           CSC_LINK: ${{ matrix.platform == 'macOS' && secrets.CSC_LINK || (matrix.platform == 'windows' && secrets.WIN_CSC_LINK || '') }}
           CSC_KEY_PASSWORD: ${{ matrix.platform == 'macOS' && secrets.CSC_KEY_PASSWORD || (matrix.platform == 'windows' && secrets.WIN_CSC_KEY_PASSWORD || '') }}

.vscode/settings.json

@@ -15,7 +15,14 @@
   "[typescript]": {
     "editor.defaultFormatter": "biomejs.biome"
   },
-  "cSpell.words": ["Atlassify", "codegen", "partialize", "rovo", "xcss"],
+  "cSpell.words": [
+    "atlassify",
+    "codegen",
+    "partialize",
+    "rovo",
+    "xcss",
+    "aptabase"
+  ],
   "i18n-ally.translate.engines": ["google"],
   "i18n-ally.localesPaths": ["src/renderer/i18n/locales"],
   "i18n-ally.sourceLanguage": "en",

package.json

@@ -111,7 +111,6 @@
     "clsx": "2.1.1",
     "concurrently": "9.2.1",
     "date-fns": "4.1.0",
-    "dotenv": "17.3.1",
     "electron": "41.0.3",
     "electron-builder": "26.8.1",
     "graphql": "16.13.1",

pnpm-lock.yaml

@@ -25,28 +25,26 @@ vi.mock('../../shared/logger', () => ({
 }));
 
 describe('main/handlers/analytics.ts', () => {
-  const originalEnv = process.env;
-
-  beforeEach(() => {
-    process.env = { ...originalEnv };
+  afterEach(() => {
+    vi.unstubAllEnvs();
   });
 
   describe('initializeAnalytics', () => {
-    it('logs an error and skips initialization when APTABASE_KEY is not set', async () => {
-      delete process.env.APTABASE_KEY;
+    it('logs an error and skips initialization when VITE_APTABASE_KEY is not set', async () => {
+      vi.stubEnv('VITE_APTABASE_KEY', '');
 
       await initializeAnalytics();
 
       expect(initializeMock).not.toHaveBeenCalled();
       expect(logErrorMock).toHaveBeenCalledWith(
         'analytics',
-        'APTABASE_KEY environment variable is not set',
+        'VITE_APTABASE_KEY environment variable is not set',
         expect.any(Error),
       );
     });
 
-    it('initializes the SDK and logs success when APTABASE_KEY is set', async () => {
-      process.env.APTABASE_KEY = 'test-key-123';
+    it('initializes the SDK and logs success when VITE_APTABASE_KEY is set', async () => {
+      vi.stubEnv('VITE_APTABASE_KEY', 'test-key-123');
 
       await initializeAnalytics();
 
@@ -59,7 +57,7 @@ describe('main/handlers/analytics.ts', () => {
     });
 
     it('logs an error when SDK initialization throws', async () => {
-      process.env.APTABASE_KEY = 'test-key-123';
+      vi.stubEnv('VITE_APTABASE_KEY', 'test-key-123');
       const sdkError = new Error('SDK init failed');
       initializeMock.mockImplementationOnce(() => {
         throw sdkError;

src/main/handlers/analytics.test.ts

@@ -6,16 +6,16 @@ import { logError, logInfo } from '../../shared/logger';
 import { onMainEvent } from '../events';
 
 /**
- * Initialize the Aptabase analytics SDK using the APTABASE_KEY environment variable.
+ * Initialize the Aptabase analytics SDK using the VITE_APTABASE_KEY environment variable.
  */
 export async function initializeAnalytics(): Promise<void> {
-  const aptabaseKey = process.env.APTABASE_KEY;
+  const aptabaseKey = import.meta.env.VITE_APTABASE_KEY;
 
   if (!aptabaseKey) {
     logError(
       'analytics',
-      'APTABASE_KEY environment variable is not set',
-      new Error('APTABASE_KEY environment variable is not set'),
+      'VITE_APTABASE_KEY environment variable is not set',
+      new Error('VITE_APTABASE_KEY environment variable is not set'),
     );
     return;
   }

src/main/handlers/analytics.ts

@@ -1,7 +1,3 @@
-import { config } from 'dotenv';
-
-config();
-
 import { app } from 'electron';
 import log from 'electron-log';
 import { menubar } from 'menubar';