Refactor mock OpenAI client in tests and enhance CLI output verification

Author: setkyar

tests/test_main.py

@@ -1,6 +1,7 @@
 import pytest
+import os
 from click.testing import CliRunner
-from unittest.mock import patch
+from unittest.mock import patch, Mock
 from aireview.main import main
 
 @pytest.fixture
@@ -22,18 +23,16 @@ def mock_git_with_changes():
 @pytest.fixture
 def mock_openai():
     """Mock OpenAI client"""
+    mock_completion = Mock()
+    mock_completion.choices = [Mock(message=Mock(content="Test review content"))]
+
+    mock_chat = Mock()
+    mock_chat.completions.create.return_value = mock_completion
+
+    mock_client = Mock()
+    mock_client.chat = mock_chat
+
     with patch('aireview.ai_reviewer.OpenAI') as mock:
-        mock_client = type('MockClient', (), {
-            'chat': type('MockChat', (), {
-                'completions': type('MockCompletions', (), {
-                    'create': lambda **kwargs: type('MockResponse', (), {
-                        'choices': [type('MockChoice', (), {
-                            'message': type('MockMessage', (), {'content': 'Test review'})
-                        })()]
-                    })()
-                })()
-            })()
-        })()
         mock.return_value = mock_client
         yield mock
 
@@ -46,10 +45,29 @@ def test_main_cli_no_changes(temp_config_file, mock_git_no_changes):
 
 def test_main_cli_with_changes(temp_config_file, mock_git_with_changes, mock_openai):
     """Test CLI with git changes."""
+    # Get the output file path from the config
+    import configparser
+    config = configparser.ConfigParser()
+    config.read(temp_config_file)
+    output_file = config.get("review", "output", fallback="review.md")
+
     runner = CliRunner()
     result = runner.invoke(main, ['--config', temp_config_file])
+    
+    # Check CLI output
     assert result.exit_code == 0
-    assert "Getting review for test.py" in result.output
+    assert "Generating review for test.py" in result.output
+    assert f"AI review written to {output_file}" in result.output
+    
+    # Check review file content
+    assert os.path.exists(output_file)
+    with open(output_file, 'r') as f:
+        content = f.read()
+        assert "Test review content" in content
+    
+    # Cleanup
+    if os.path.exists(output_file):
+        os.remove(output_file)
 
 def test_main_cli_invalid_config():
     """Test CLI with invalid config file."""