Skip to content

Commit 2b254d7

Browse files
committed
Update messages
1 parent 99ddd24 commit 2b254d7

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

CHANGES.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414
* `hasher` will no longer create a directory if a non-existing one is passed as an argument.
1515
* trivrost will no longer attempt to repeat range requests to a host after it has failed to conformly respond while displaying the confusing message `Taking longer than usual: HTTP Status 200` and will now fail immediately in such cases instead.
1616
* trivrost will no longer fail to comply with HTTP 2 strictly using lower-case HTTP Header names. This had been caused by methods of `http.Header` still being oriented around HTTP 1 canonical header names due to Go's backwards compatibility promise.
17+
* Instead of always showing 'Cannot reach server' to the user, show more precise/useful messages on connection issues.
1718

1819
## 1.4.6 (2021-01-25)
1920
### Fixes

cmd/launcher/gui/gui_progress_handler.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -75,11 +75,11 @@ func (handler *GuiDownloadProgressHandler) HandleHttpGetError(fromURL string, er
7575
handler.problemUrl = fromURL
7676

7777
if strings.Contains(err.Error(), "x509: ") {
78-
NotifyProblem("Certificate verification problem", false)
79-
} else if strings.Contains(err.Error(), "timed out") {
80-
NotifyProblem("Timeout reaching server", false)
78+
NotifyProblem("Certificate (X.509) problem", false)
79+
} else if strings.Contains(err.Error(), "dial tcp: lookup") && strings.Contains(err.Error(), "no such host") {
80+
NotifyProblem("Unable to resolve hostname", false)
8181
} else {
82-
NotifyProblem("Problems reaching server", false)
82+
NotifyProblem("Connection problem", false)
8383
}
8484
}
8585

0 commit comments

Comments
 (0)