Replace misc type with standard library type (#100)

Replace misc type with standard library type

Author: MMulthaupt

pkg/launcher/config/deployment_config_test.go

@@ -0,0 +1,25 @@
+package config_test
+
+import (
+	"os"
+	"testing"
+
+	"github.com/setlog/trivrost/pkg/launcher/config"
+	"github.com/setlog/trivrost/pkg/system"
+)
+
+func TestDeploymentConfigWithTemplates(t *testing.T) {
+	f, err := os.Open("test/dpc_template.json")
+	if err != nil {
+		t.Fatal(err)
+	}
+	defer f.Close()
+	configString, err := config.ReadDeploymentConfig(f, "AmigaOS", "68000x16")
+	if err != nil {
+		t.Fatal(err)
+	}
+	expectedConfigString := string(system.MustReadFile("test/dpc_template.expected.json"))
+	if configString != expectedConfigString {
+		t.Fatalf("Files do not match. Expected: \n%s\nActual:\n%s\n", expectedConfigString, configString)
+	}
+}

pkg/launcher/config/template.go

@@ -2,9 +2,8 @@ package config
 
 import (
 	"fmt"
+	"strings"
 	"text/template"
-
-	"github.com/setlog/trivrost/pkg/misc"
 )
 
 type templateFields struct {
@@ -18,11 +17,11 @@ func expandPlaceholders(s string, os string, arch string) (string, error) {
 		return "", fmt.Errorf("Could not parse template: %v", err)
 	}
 
-	dw := &misc.ByteSliceWriter{}
-	err = tmpl.Execute(dw, templateFields{os, arch})
+	sb := &strings.Builder{}
+	err = tmpl.Execute(sb, templateFields{os, arch})
 	if err != nil {
 		return "", fmt.Errorf("Could not execute template: %v", err)
 	}
 
-	return string(dw.Data), nil
+	return sb.String(), nil
 }

pkg/launcher/config/test/dpc_template.expected.json

@@ -0,0 +1,8 @@
+{
+    "LauncherUpdate": [
+        {
+            "BundleInfoURL": "https://example.com/windows/launcher/bundleinfo.json",
+            "TargetPlatforms": [ "AmigaOS-68000x16" ]
+        }
+    ]
+}

pkg/launcher/config/test/dpc_template.json

@@ -0,0 +1,8 @@
+{
+    "LauncherUpdate": [
+        {
+            "BundleInfoURL": "https://example.com/windows/launcher/bundleinfo.json",
+            "TargetPlatforms": [ "{{.OS}}-{{.Arch}}" ]
+        }
+    ]
+}