Skip to content

Commit a1a1340

Browse files
committed
Merge branch 'develop' into fix/server_error_messages
2 parents cbfe953 + 6b77d54 commit a1a1340

File tree

4 files changed

+12
-56
lines changed

4 files changed

+12
-56
lines changed

CHANGES.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,10 @@
1515
* trivrost will no longer attempt to repeat range requests to a host after it has failed to conformly respond while displaying the confusing message `Taking longer than usual: HTTP Status 200` and will now fail immediately in such cases instead.
1616
* trivrost will no longer fail to comply with HTTP 2 strictly using lower-case HTTP Header names. This had been caused by methods of `http.Header` still being oriented around HTTP 1 canonical header names due to Go's backwards compatibility promise.
1717

18+
## 1.4.6 (2021-01-25)
19+
### Fixes
20+
* Windows binary signing: Use RFC-3161 timestamp server with sha 256 config. SHA-1 ciphers are considered deprecated. Nothing should change for the enduser.
21+
1822
## 1.4.5 (2021-01-04)
1923
### Fixes
2024
* Switch timestamp server for signing from Verisign to Globalsign.

Makefile

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ ifndef VERSIONOK
3232
endif
3333
$(info GIT description: '${GITDESC}' (latest master: '${LAUNCHER_VERSION}'), GIT branch '${GITBRANCH}', GIT hash '${GITHASH}')
3434

35-
TIMESTAMP_SERVER = 'http://timestamp.globalsign.com/scripts/timstamp.dll'
35+
TIMESTAMP_SERVER = 'http://rfc3161timestamp.globalsign.com/advanced'
3636

3737
#
3838
# Detect OS
@@ -150,7 +150,7 @@ ifndef CERT_KEY
150150
endif
151151
$(info Signing windows release files...)
152152
echo "$${CERT_FILE}" | base64 -d > ~tmp_launcher_cert
153-
@signtool sign /debug /a /v /d "${LAUNCHER_BRANDING_NAME}" /f ~tmp_launcher_cert /p "${CERT_KEY}" /t ${TIMESTAMP_SERVER} /fd SHA512 "${UPDATE_FILES_DIR}/${OS}/${LAUNCHER_PROGRAM_NAME}.exe"
153+
@signtool sign /debug /a /v /d "${LAUNCHER_BRANDING_NAME}" /f ~tmp_launcher_cert /p "${CERT_KEY}" /tr ${TIMESTAMP_SERVER} /td SHA256 /fd SHA512 "${UPDATE_FILES_DIR}/${OS}/${LAUNCHER_PROGRAM_NAME}.exe"
154154
rm ~tmp_launcher_cert
155155
endif
156156

@@ -166,8 +166,8 @@ ifneq (${OS},windows)
166166
else
167167
$(info Signing windows release files...)
168168
echo "$${CERT_FILE}" | base64 -d > ~tmp_launcher_cert
169-
@signtool sign /debug /a /v /d "${LAUNCHER_BRANDING_NAME}" /f ~tmp_launcher_cert /p "${CERT_KEY}" /t ${TIMESTAMP_SERVER} /fd SHA512 "${RELEASE_FILES_DIR}/${OS}/${LAUNCHER_PROGRAM_NAME}_386.msi"
170-
@signtool sign /debug /a /v /d "${LAUNCHER_BRANDING_NAME}" /f ~tmp_launcher_cert /p "${CERT_KEY}" /t ${TIMESTAMP_SERVER} /fd SHA512 "${RELEASE_FILES_DIR}/${OS}/${LAUNCHER_PROGRAM_NAME}_amd64.msi"
169+
@signtool sign /debug /a /v /d "${LAUNCHER_BRANDING_NAME}" /f ~tmp_launcher_cert /p "${CERT_KEY}" /tr ${TIMESTAMP_SERVER} /td SHA256 /fd SHA512 "${RELEASE_FILES_DIR}/${OS}/${LAUNCHER_PROGRAM_NAME}_386.msi"
170+
@signtool sign /debug /a /v /d "${LAUNCHER_BRANDING_NAME}" /f ~tmp_launcher_cert /p "${CERT_KEY}" /tr ${TIMESTAMP_SERVER} /td SHA256 /fd SHA512 "${RELEASE_FILES_DIR}/${OS}/${LAUNCHER_PROGRAM_NAME}_amd64.msi"
171171
rm ~tmp_launcher_cert
172172
endif
173173

go.mod

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ module github.com/setlog/trivrost
33
require (
44
git.sr.ht/~tslocum/preallocate v0.1.1
55
github.com/MMulthaupt/chronometry v0.1.1
6+
github.com/StackExchange/wmi v0.0.0-20190523213315-cbe66965904d // indirect
67
github.com/andlabs/ui v0.0.0-20200610043537-70a69d6ae31e
78
github.com/davecgh/go-spew v1.1.1
89
github.com/fatih/color v1.10.0
@@ -11,9 +12,9 @@ require (
1112
github.com/mattn/go-ieproxy v0.0.1
1213
github.com/prometheus/client_golang v1.10.0
1314
github.com/shirou/gopsutil v3.21.3+incompatible
14-
github.com/shirou/gopsutil/v3 v3.21.3
1515
github.com/sirupsen/logrus v1.8.1
1616
github.com/stretchr/testify v1.7.0
17+
github.com/tklauser/go-sysconf v0.3.4 // indirect
1718
github.com/xeipuuv/gojsonschema v1.2.0
1819
golang.org/x/net v0.0.0-20200625001655-4c5254603344
1920
golang.org/x/sys v0.0.0-20210309074719-68d13333faf2

0 commit comments

Comments
 (0)