cmake: Use stricter include paths for src/ast

The target_include_directories() on parser target was leaking into other
cmake targets. Making include paths stricter keeps the code more
uniform. It also matters for stricter build systems like buck.

Author: danobi

CMakeLists.txt

@@ -112,7 +112,7 @@ flex_target(flex_lexer src/lexer.l ${CMAKE_BINARY_DIR}/lex.yy.cc)
 add_flex_bison_dependency(flex_lexer bison_parser)
 add_library(parser STATIC ${BISON_bison_parser_OUTPUTS} ${FLEX_flex_lexer_OUTPUTS})
 target_compile_options(parser PRIVATE "-w")
-target_include_directories(parser PUBLIC src src/ast ${CMAKE_BINARY_DIR})
+target_include_directories(parser PRIVATE src src/ast ${CMAKE_BINARY_DIR})
 
 include(CheckSymbolExists)
 set(CMAKE_REQUIRED_DEFINITIONS -D_GNU_SOURCE)

src/ast/passes/resource_analyser.cpp

@@ -3,8 +3,8 @@
 #include <algorithm>
 
 #include "ast/async_event_types.h"
+#include "ast/codegen_helper.h"
 #include "bpftrace.h"
-#include "codegen_helper.h"
 #include "globalvars.h"
 #include "log.h"
 #include "struct.h"

tests/bpfbytecode.cpp

@@ -1,8 +1,8 @@
 #include "bpfbytecode.h"
+#include "ast/passes/codegen_llvm.h"
+#include "ast/passes/semantic_analyser.h"
 #include "driver.h"
 #include "mocks.h"
-#include "passes/codegen_llvm.h"
-#include "passes/semantic_analyser.h"
 
 #include "gtest/gtest.h"