minor: fix violations from RedundantThisCheck

Author: wilcoln

sevntu-checks/src/main/java/com/github/sevntu/checkstyle/checks/annotation/RequiredParameterForAnnotationCheck.java

@@ -129,7 +129,7 @@ public void setAnnotationName(String annotationName) {
      */
     public void setRequiredParameters(String... requiredPropertiesParameter) {
         for (String item : requiredPropertiesParameter) {
-            this.requiredParameters.add(item);
+            requiredParameters.add(item);
         }
     }
 
@@ -156,13 +156,13 @@ public int[] getAcceptableTokens() {
     public void visitToken(DetailAST annotationNode) {
         final String annotationNameCheck = getAnnotationName(annotationNode);
 
-        if (annotationNameCheck.equals(this.annotationName)) {
+        if (annotationNameCheck.equals(annotationName)) {
             final Set<String> missingParameters =
                     Sets.difference(requiredParameters, getAnnotationParameters(annotationNode));
 
             if (!missingParameters.isEmpty()) {
                 final String missingParametersAsString = Joiner.on(", ").join(missingParameters);
-                log(annotationNode, MSG_KEY, this.annotationName, missingParametersAsString);
+                log(annotationNode, MSG_KEY, annotationName, missingParametersAsString);
             }
         }
     }

sevntu-checks/src/main/java/com/github/sevntu/checkstyle/checks/coding/AvoidDefaultSerializableInInnerClassesCheck.java

@@ -58,7 +58,7 @@ public class AvoidDefaultSerializableInInnerClassesCheck extends AbstractCheck {
      *        of serializable interface.
      */
     public void setAllowPartialImplementation(boolean allow) {
-        this.allowPartialImplementation = allow;
+        allowPartialImplementation = allow;
     }
 
     @Override

sevntu-checks/src/main/java/com/github/sevntu/checkstyle/checks/coding/CustomDeclarationOrderCheck.java

@@ -1247,7 +1247,7 @@ public void setCompileFlags(final int compileFlags) {
         private void updateRegexp(final String newFormat, final int compileFlags) {
             try {
                 regExp = Pattern.compile(newFormat, compileFlags);
-                this.format = newFormat;
+                format = newFormat;
             }
             catch (final PatternSyntaxException ex) {
                 throw new IllegalArgumentException("unable to parse " + newFormat, ex);
@@ -1260,7 +1260,7 @@ private void updateRegexp(final String newFormat, final int compileFlags) {
          * @return true if format matcher contains rule.
          */
         public boolean hasRule(String ruleCheck) {
-            return this.rule.indexOf(ruleCheck) > -1;
+            return rule.indexOf(ruleCheck) > -1;
         }
 
         @Override

sevntu-checks/src/main/java/com/github/sevntu/checkstyle/checks/coding/ForbidThrowAnonymousExceptionsCheck.java

@@ -81,7 +81,7 @@ public class ForbidThrowAnonymousExceptionsCheck extends AbstractCheck {
      * @param exceptionClassNameRegex The regular expression to set.
      */
     public void setExceptionClassNameRegex(String exceptionClassNameRegex) {
-        this.pattern = Pattern.compile(exceptionClassNameRegex);
+        pattern = Pattern.compile(exceptionClassNameRegex);
     }
 
     @Override

sevntu-checks/src/main/java/com/github/sevntu/checkstyle/checks/coding/Jsr305AnnotationsCheck.java

@@ -310,7 +310,7 @@ private enum NullnessAnnotation {
          */
         NullnessAnnotation(final String annotationName, final String packageName) {
             this.annotationName = annotationName;
-            this.fullyQualifiedClassName = packageName + "." + annotationName;
+            fullyQualifiedClassName = packageName + "." + annotationName;
         }
 
     }
@@ -397,7 +397,7 @@ public void setExcludePackages(final String... packageNames) {
      *        true if yes
      */
     public void setAllowOverridingReturnValue(final boolean newAllowOverridingReturnValue) {
-        this.allowOverridingReturnValue = newAllowOverridingReturnValue;
+        allowOverridingReturnValue = newAllowOverridingReturnValue;
     }
 
     /**
@@ -406,7 +406,7 @@ public void setAllowOverridingReturnValue(final boolean newAllowOverridingReturn
      *        true if yes
      */
     public void setAllowOverridingParameter(final boolean newAllowOverridingParameter) {
-        this.allowOverridingParameter = newAllowOverridingParameter;
+        allowOverridingParameter = newAllowOverridingParameter;
     }
 
     /**
@@ -865,7 +865,7 @@ public abstract class AbstractJsr305Handler {
          */
         private AbstractJsr305Handler(final DetailAST ast) {
             this.ast = ast;
-            this.violationFound = false;
+            violationFound = false;
             annotations = findAnnotations(ast);
         }
 
@@ -911,9 +911,9 @@ protected void checkContainsAny(final String msg, final NullnessAnnotation... se
          */
         private boolean containsAny(final NullnessAnnotation... search) {
             boolean result = false;
-            if (!this.annotations.isEmpty()) {
+            if (!annotations.isEmpty()) {
                 for (final NullnessAnnotation obj : search) {
-                    if (this.annotations.contains(obj)) {
+                    if (annotations.contains(obj)) {
                         result = true;
                         break;
                     }
@@ -946,7 +946,7 @@ protected void checkRedundancyDueToClassLevelAnnotation(final String msg,
                 final NullnessAnnotation... search) {
             if (!violationFound) {
                 for (final NullnessAnnotation nullnessAnnotation : search) {
-                    final boolean thisIsAnnotated = this.annotations.contains(nullnessAnnotation);
+                    final boolean thisIsAnnotated = annotations.contains(nullnessAnnotation);
                     final boolean parentIsAnnotated =
                             getParentMethodOrClassAnnotation(nullnessAnnotation) != null;
                     if (thisIsAnnotated && parentIsAnnotated) {
@@ -965,13 +965,13 @@ protected void checkRedundancyDueToClassLevelAnnotation(final String msg,
          */
         private boolean containsAll(final NullnessAnnotation... search) {
             boolean result = true;
-            if (this.annotations.isEmpty()) {
+            if (annotations.isEmpty()) {
                 // an empty list of annotations can never contain all
                 result = false;
             }
             else {
                 for (final NullnessAnnotation obj : search) {
-                    if (!this.annotations.contains(obj)) {
+                    if (!annotations.contains(obj)) {
                         result = false;
                         break;
                     }

sevntu-checks/src/main/java/com/github/sevntu/checkstyle/checks/coding/OverridableMethodInConstructorCheck.java

@@ -926,7 +926,7 @@ private final class OverridableMetCall {
          */
         /* package */ OverridableMetCall(DetailAST methodCallAST,
                 String overridableMetName) {
-            this.metCallAST = methodCallAST;
+            metCallAST = methodCallAST;
             this.overridableMetName = overridableMetName;
         }
 

sevntu-checks/src/main/java/com/github/sevntu/checkstyle/checks/naming/UniformEnumConstantNameCheck.java

@@ -126,7 +126,7 @@ public UniformEnumConstantNameCheck() {
      * @param regexps format to check against
      */
     public final void setFormats(String... regexps) {
-        this.patterns = new ArrayList<>(regexps.length);
+        patterns = new ArrayList<>(regexps.length);
         for (final String regexp: regexps) {
             final Pattern pattern = Pattern.compile(regexp, 0);
             patterns.add(pattern);