Skip to content

Commit 3630517

Browse files
committed
Update idp-configuration-id in tests to use UUID
1 parent 88629f2 commit 3630517

File tree

3 files changed

+8
-4
lines changed

3 files changed

+8
-4
lines changed

test/assets/user_add.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
<?xml version='1.0' encoding='UTF-8'?>
22
<tsResponse xmlns="http://tableau.com/api" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://tableau.com/api http://tableau.com/api/ts-api-2.3.xsd">
3-
<user id="4cc4c17f-898a-4de4-abed-a1681c673ced" name="Cassie" siteRole="Viewer" authSetting="ServerDefault" externalAuthUserId="" idpConfigurationId="test-idp-id" />
3+
<user id="4cc4c17f-898a-4de4-abed-a1681c673ced" name="Cassie" siteRole="Viewer" authSetting="ServerDefault" externalAuthUserId="" idpConfigurationId="b47f41b1-2c47-41a3-8b17-a38ebe8b340c" />
44
</tsResponse>

test/test_user.py

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
import os
22
import unittest
3+
import uuid
34

45
import requests_mock
56

@@ -132,16 +133,18 @@ def test_add(self) -> None:
132133
response_xml = f.read().decode("utf-8")
133134
with requests_mock.mock() as m:
134135
m.post(self.baseurl + "", text=response_xml)
136+
# Use a fixed UUID for testing so it matches the XML response
137+
test_idp_id = "b47f41b1-2c47-41a3-8b17-a38ebe8b340c"
135138
new_user = TSC.UserItem(
136-
name="Cassie", site_role="Viewer", auth_setting="ServerDefault", idp_configuration_id="test-idp-id"
139+
name="Cassie", site_role="Viewer", auth_setting="ServerDefault", idp_configuration_id=test_idp_id
137140
)
138141
new_user = self.server.users.add(new_user)
139142

140143
self.assertEqual("4cc4c17f-898a-4de4-abed-a1681c673ced", new_user.id)
141144
self.assertEqual("Cassie", new_user.name)
142145
self.assertEqual("Viewer", new_user.site_role)
143146
self.assertEqual("ServerDefault", new_user.auth_setting)
144-
self.assertEqual("test-idp-id", new_user.idp_configuration_id)
147+
self.assertEqual(test_idp_id, new_user.idp_configuration_id)
145148

146149
def test_populate_workbooks(self) -> None:
147150
with open(POPULATE_WORKBOOKS_XML, "rb") as f:

test/test_user_model.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
import unittest
33
from unittest.mock import *
44
import io
5+
import uuid
56

67
import pytest
78

@@ -20,7 +21,7 @@ def test_invalid_site_role(self):
2021
user.site_role = "Hello"
2122

2223
def test_idp_configuration_id(self):
23-
idp_id = "idp123"
24+
idp_id = str(uuid.uuid4())
2425
user = TSC.UserItem("test", "Viewer", auth_setting="SAML", idp_configuration_id=idp_id)
2526
self.assertEqual(idp_id, user.idp_configuration_id)
2627

0 commit comments

Comments
 (0)