Skip to content

Commit 3aac745

Browse files
authored
Merge pull request #1 from sfackler/master
update
2 parents e3a25ad + e57a297 commit 3aac745

File tree

3 files changed

+20
-11
lines changed

3 files changed

+20
-11
lines changed

postgres/src/query.rs

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,11 @@ impl<'a> Query<'a> {
2121
_p: PhantomData,
2222
}
2323
}
24+
25+
/// A convenience API which collects the resulting rows into a `Vec` and returns them.
26+
pub fn into_vec(self) -> Result<Vec<Row>, Error> {
27+
self.collect()
28+
}
2429
}
2530

2631
impl<'a> FallibleIterator for Query<'a> {

postgres/src/query_portal.rs

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,11 @@ impl<'a> QueryPortal<'a> {
2121
_p: PhantomData,
2222
}
2323
}
24+
25+
/// A convenience API which collects the resulting rows into a `Vec` and returns them.
26+
pub fn into_vec(self) -> Result<Vec<Row>, Error> {
27+
self.collect()
28+
}
2429
}
2530

2631
impl<'a> FallibleIterator for QueryPortal<'a> {

postgres/src/test.rs

Lines changed: 10 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
use fallible_iterator::FallibleIterator;
21
use std::io::Read;
32
use tokio_postgres::types::Type;
43
use tokio_postgres::NoTls;
@@ -24,7 +23,7 @@ fn query_prepared() {
2423
let rows = client
2524
.query(&stmt, &[&"hello"])
2625
.unwrap()
27-
.collect::<Vec<_>>()
26+
.into_vec()
2827
.unwrap();
2928
assert_eq!(rows.len(), 1);
3029
assert_eq!(rows[0].get::<_, &str>(0), "hello");
@@ -37,7 +36,7 @@ fn query_unprepared() {
3736
let rows = client
3837
.query("SELECT $1::TEXT", &[&"hello"])
3938
.unwrap()
40-
.collect::<Vec<_>>()
39+
.into_vec()
4140
.unwrap();
4241
assert_eq!(rows.len(), 1);
4342
assert_eq!(rows[0].get::<_, &str>(0), "hello");
@@ -62,7 +61,7 @@ fn transaction_commit() {
6261
let rows = client
6362
.query("SELECT * FROM foo", &[])
6463
.unwrap()
65-
.collect::<Vec<_>>()
64+
.into_vec()
6665
.unwrap();
6766
assert_eq!(rows.len(), 1);
6867
assert_eq!(rows[0].get::<_, i32>(0), 1);
@@ -87,7 +86,7 @@ fn transaction_rollback() {
8786
let rows = client
8887
.query("SELECT * FROM foo", &[])
8988
.unwrap()
90-
.collect::<Vec<_>>()
89+
.into_vec()
9190
.unwrap();
9291
assert_eq!(rows.len(), 0);
9392
}
@@ -111,7 +110,7 @@ fn transaction_drop() {
111110
let rows = client
112111
.query("SELECT * FROM foo", &[])
113112
.unwrap()
114-
.collect::<Vec<_>>()
113+
.into_vec()
115114
.unwrap();
116115
assert_eq!(rows.len(), 0);
117116
}
@@ -141,7 +140,7 @@ fn nested_transactions() {
141140
let rows = transaction
142141
.query("SELECT id FROM foo ORDER BY id", &[])
143142
.unwrap()
144-
.collect::<Vec<_>>()
143+
.into_vec()
145144
.unwrap();
146145
assert_eq!(rows.len(), 1);
147146
assert_eq!(rows[0].get::<_, i32>(0), 1);
@@ -165,7 +164,7 @@ fn nested_transactions() {
165164
let rows = client
166165
.query("SELECT id FROM foo ORDER BY id", &[])
167166
.unwrap()
168-
.collect::<Vec<_>>()
167+
.into_vec()
169168
.unwrap();
170169
assert_eq!(rows.len(), 3);
171170
assert_eq!(rows[0].get::<_, i32>(0), 1);
@@ -192,7 +191,7 @@ fn copy_in() {
192191
let rows = client
193192
.query("SELECT id, name FROM foo ORDER BY id", &[])
194193
.unwrap()
195-
.collect::<Vec<_>>()
194+
.into_vec()
196195
.unwrap();
197196

198197
assert_eq!(rows.len(), 2);
@@ -251,7 +250,7 @@ fn portal() {
251250
let rows = transaction
252251
.query_portal(&portal, 2)
253252
.unwrap()
254-
.collect::<Vec<_>>()
253+
.into_vec()
255254
.unwrap();
256255
assert_eq!(rows.len(), 2);
257256
assert_eq!(rows[0].get::<_, i32>(0), 1);
@@ -260,7 +259,7 @@ fn portal() {
260259
let rows = transaction
261260
.query_portal(&portal, 2)
262261
.unwrap()
263-
.collect::<Vec<_>>()
262+
.into_vec()
264263
.unwrap();
265264
assert_eq!(rows.len(), 1);
266265
assert_eq!(rows[0].get::<_, i32>(0), 3);

0 commit comments

Comments
 (0)