Revert "Review fix: get_connect_timeout returns copied Option."

Hirotaka Azuma · Hirotaka Azuma · commit 5551b3e6cdd8 · 2022-08-27T14:18:27.000Z
This reverts commit 4882ecc.
diff --git a/postgres/src/config.rs b/postgres/src/config.rs
@@ -252,7 +252,7 @@ impl Config {
 
     /// Gets the connection timeout, if one has been set with the
     /// `connect_timeout` method.
-    pub fn get_connect_timeout(&self) -> Option<Duration> {
+    pub fn get_connect_timeout(&self) -> Option<&Duration> {
         self.config.get_connect_timeout()
     }
 
diff --git a/tokio-postgres/src/config.rs b/tokio-postgres/src/config.rs
@@ -336,8 +336,8 @@ impl Config {
 
     /// Gets the connection timeout, if one has been set with the
     /// `connect_timeout` method.
-    pub fn get_connect_timeout(&self) -> Option<Duration> {
-        self.connect_timeout.as_ref().copied()
+    pub fn get_connect_timeout(&self) -> Option<&Duration> {
+        self.connect_timeout.as_ref()
     }
 
     /// Controls the use of TCP keepalive.

Original file line number	Diff line number	Diff line change
`@@ -252,7 +252,7 @@ impl Config {`
`252`	`252`
`253`	`253`	`/// Gets the connection timeout, if one has been set with the`
`254`	`254`	/// `connect_timeout` method.
`255`		`- pub fn get_connect_timeout(&self) -> Option<Duration> {`
	`255`	`+ pub fn get_connect_timeout(&self) -> Option<&Duration> {`
`256`	`256`	`self.config.get_connect_timeout()`
`257`	`257`	`}`
`258`	`258`
Original file line number	Diff line number	Diff line change
`@@ -336,8 +336,8 @@ impl Config {`
`336`	`336`
`337`	`337`	`/// Gets the connection timeout, if one has been set with the`
`338`	`338`	/// `connect_timeout` method.
`339`		`- pub fn get_connect_timeout(&self) -> Option<Duration> {`
`340`		`- self.connect_timeout.as_ref().copied()`
	`339`	`+ pub fn get_connect_timeout(&self) -> Option<&Duration> {`
	`340`	`+ self.connect_timeout.as_ref()`
`341`	`341`	`}`
`342`	`342`
`343`	`343`	`/// Controls the use of TCP keepalive.`