Look up column names case insensitively

It tries a case sensitive comparison first so all existing uses should
continue to be OK. It should really have some form of unicode awarenes
but it's unclear exactly what. The JDBC driver uses the US locale when
lowercasing and libpq uses tolower with the system locale.

Closes #136

Author: sfackler

src/rows.rs

@@ -1,5 +1,6 @@
 //! Query result rows.
 
+use std::ascii::AsciiExt;
 use std::fmt;
 use std::collections::VecDeque;
 use debug_builders::DebugStruct;
@@ -274,7 +275,14 @@ impl RowIndex for usize {
 impl<'a> RowIndex for &'a str {
     #[inline]
     fn idx(&self, stmt: &Statement) -> Option<usize> {
-        stmt.columns().iter().position(|d| d.name == *self)
+        if let Some(idx) = stmt.columns().iter().position(|d| d.name == *self) {
+            return Some(idx);
+        };
+
+        // FIXME ASCII-only case insensitivity isn't really the right thing to
+        // do. Postgres itself uses a dubious wrapper around tolower and JDBC
+        // uses the US locale.
+        stmt.columns().iter().position(|d| d.name.eq_ignore_ascii_case(*self))
     }
 }
 

tests/test.rs

@@ -25,6 +25,7 @@ use postgres::error::SqlState::{SyntaxError,
                                 InvalidPassword,
                                 CardinalityViolation};
 use postgres::error::ErrorPosition::Normal;
+use postgres::rows::RowIndex;
 
 macro_rules! or_panic {
     ($e:expr) => (
@@ -886,3 +887,15 @@ fn test_rows_index() {
     assert_eq!(3, rows.len());
     assert_eq!(2i32, rows.get(1).get(0));
 }
+
+#[test]
+fn test_row_case_insensitive() {
+    let conn = Connection::connect("postgres://postgres@localhost", &SslMode::None).unwrap();
+    conn.batch_execute("CREATE TEMPORARY TABLE foo (foo INT, \"bAr\" INT, \"Bar\" INT);").unwrap();
+    let stmt = conn.prepare("SELECT * FROM foo").unwrap();
+    assert_eq!(Some(0), "foo".idx(&stmt));
+    assert_eq!(Some(0), "FOO".idx(&stmt));
+    assert_eq!(Some(1), "bar".idx(&stmt));
+    assert_eq!(Some(1), "bAr".idx(&stmt));
+    assert_eq!(Some(2), "Bar".idx(&stmt));
+}