Skip to content

Commit 3c61d06

Browse files
authored
- fix typo (envoyproxy#226)
- fix issue with duplicate envoy_release file - change logic that compares current to latest envoy version Signed-off-by: rulex123 <[email protected]>
1 parent 9b26d17 commit 3c61d06

File tree

4 files changed

+5
-6
lines changed

4 files changed

+5
-6
lines changed

.github/workflows/compare-envoy-versions.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -23,14 +23,14 @@ jobs:
2323
id: current-envoy-version
2424
run: |
2525
echo 'ENVOY_CURRENT<<EOF' >> $GITHUB_ENV
26-
cat envoy_release >> $GITHUB_ENV
26+
cat ./tools/envoy_release >> $GITHUB_ENV
2727
echo 'EOF' >> $GITHUB_ENV
2828
- name: Compare latest to current
2929
id: compare-latest-to-current-version
3030
run: |
31-
if [[ "${{ env.ENVOY_LATEST }}" == "${{ env.ENVOY_CURRENT }}" ]]
31+
if [[ "${{ env.ENVOY_LATEST }}" > "${{ env.ENVOY_CURRENT }}" ]]
3232
then
33-
echo "::set-output name=target-version::noop"
34-
else
3533
echo "::set-output name=target-version::${{ env.ENVOY_LATEST }}"
34+
else
35+
echo "::set-output name=target-version::noop"
3636
fi

envoy_release

Lines changed: 0 additions & 1 deletion
This file was deleted.
File renamed without changes.

tools/update-sha.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,4 +62,4 @@ UDPA_SHA=\"$UDPA_SHA\" # $UDPA_DATE
6262
sed -i 's/\(envoy-dev:\).*\(\");\)/\1'"$ENVOY_VERSION"'\2/g' ../server/src/test/java/io/envoyproxy/controlplane/server/EnvoyContainer.java
6363

6464
# update tag in envoy_release file
65-
echo $1 > enovy_release
65+
echo $1 > envoy_release

0 commit comments

Comments
 (0)