-
Notifications
You must be signed in to change notification settings - Fork 218
Checklist for PR reviewer
Weiyüen Wu edited this page Mar 20, 2020
·
4 revisions
As a PR reviewer, you are required to ensure ALL the following items are checked.
- The PR template is filled correctly with easy understanding words.
- Screenshots are attached if UI changes involved.
- The PR is squashed and rebased against the develop branch.
- The commit messages are following the guideline and are informative as the release note.
- The PR links to the corresponding issue with "closes #xyz", if it fixes an issue.
- The code addresses all your comments.
- The PR is rebased and squashed.
- No personal information and configuration are leaked into the PR.