chore: fix linter issues

Author: Test User

.golangci.yml

@@ -18,3 +18,7 @@ linters:
     - exhaustruct
     - tagliatelle
     - noinlineerr
+    # Intentionally using time.Local for user's local timezone
+    - gosmopolitan
+    # strings.SplitSeq doesn't exist in Go 1.21
+    - modernize

cmd/gitcommit/main.go

@@ -1,3 +1,4 @@
+// Package main provides the entry point for the gitcommit CLI tool.
 package main
 
 import (

internal/cli/app.go

@@ -1,3 +1,4 @@
+// Package cli provides the command-line interface logic and orchestration for gitcommit.
 package cli
 
 import (
@@ -39,30 +40,61 @@ func (a *App) Run() error {
 	slog.Debug("Git repository detected")
 
 	// Step 2: Get last commit date (if any)
-	var lastCommitDate *time.Time
-	if git.HasCommits() {
-		lastDate, err := git.GetLastCommitDate()
-		if err != nil {
-			slog.Warn("Could not retrieve last commit date", "error", err)
-		} else {
-			lastCommitDate = &lastDate
-			slog.Debug("Last commit date retrieved", "date", lastDate)
-		}
-	} else {
+	lastCommitDate := a.getLastCommitDate()
+
+	// Step 3: Parse and validate the date
+	parsedDate, err := a.parseAndValidateDate(request.InputDate, lastCommitDate)
+	if err != nil {
+		return err
+	}
+	request.ParsedDate = parsedDate
+
+	// Step 4: Format the date for Git
+	gitFormattedDate := datetime.FormatForGit(parsedDate)
+	request.GitFormattedDate = gitFormattedDate
+	slog.Debug("Date formatted for Git", "formatted", gitFormattedDate)
+
+	// Step 5: Execute the commit
+	if err := git.ExecuteCommit(gitFormattedDate, request.CommitMessage); err != nil {
+		slog.Error("Git commit failed", "error", err)
+		return NewGitCommandError(err.Error())
+	}
+
+	// Step 6: Display success message
+	fmt.Println(FormatSuccessMessage(gitFormattedDate))
+	slog.Info("Commit created successfully")
+	return nil
+}
+
+// getLastCommitDate retrieves the last commit date from the repository.
+func (a *App) getLastCommitDate() *time.Time {
+	if !git.HasCommits() {
 		slog.Debug("No previous commits in repository")
+		return nil
 	}
 
-	// Step 3: Parse the date
-	parsedDate, err := datetime.ParseDate(request.InputDate)
+	lastDate, err := git.GetLastCommitDate()
+	if err != nil {
+		slog.Warn("Could not retrieve last commit date", "error", err)
+		return nil
+	}
+
+	slog.Debug("Last commit date retrieved", "date", lastDate)
+	return &lastDate
+}
+
+// parseAndValidateDate parses and validates the commit date.
+func (a *App) parseAndValidateDate(dateStr string, lastCommitDate *time.Time) (time.Time, error) {
+	// Parse the date
+	parsedDate, err := datetime.ParseDate(dateStr)
 	if err != nil {
 		slog.Error("Date parsing failed", "error", err)
-		return NewInvalidDateFormatError(request.InputDate)
+		return time.Time{}, NewInvalidDateFormatError(dateStr)
 	}
-	request.ParsedDate = parsedDate
 
 	slog.Debug("Date parsed successfully", "parsed", parsedDate)
 
-	// Step 4: Validate chronology
+	// Validate chronology
 	if lastCommitDate != nil {
 		valid, errorType := datetime.ValidateChronology(parsedDate, lastCommitDate)
 		if !valid {
@@ -72,7 +104,7 @@ func (a *App) Run() error {
 				"errorType", errorType)
 
 			equal := errorType == "chronology_violation_equal"
-			return NewChronologyViolationError(
+			return time.Time{}, NewChronologyViolationError(
 				datetime.FormatForGit(parsedDate),
 				datetime.FormatForGit(*lastCommitDate),
 				equal,
@@ -81,22 +113,5 @@ func (a *App) Run() error {
 	}
 
 	slog.Debug("Chronology validation passed")
-
-	// Step 5: Format the date for Git
-	gitFormattedDate := datetime.FormatForGit(parsedDate)
-	request.GitFormattedDate = gitFormattedDate
-
-	slog.Debug("Date formatted for Git", "formatted", gitFormattedDate)
-
-	// Step 6: Execute the commit
-	if err := git.ExecuteCommit(gitFormattedDate, request.CommitMessage); err != nil {
-		slog.Error("Git commit failed", "error", err)
-		return NewGitCommandError(err.Error())
-	}
-
-	// Step 7: Display success message
-	fmt.Println(FormatSuccessMessage(gitFormattedDate))
-
-	slog.Info("Commit created successfully")
-	return nil
+	return parsedDate, nil
 }

internal/cli/config.go

@@ -1,5 +1,10 @@
 package cli
 
+const (
+	// RequiredArguments is the number of arguments required for normal operation.
+	RequiredArguments = 2
+)
+
 // Config holds the configuration for the CLI application.
 type Config struct {
 	// Version is the semantic version of the tool.
@@ -30,8 +35,8 @@ func (c *Config) Validate() error {
 	}
 
 	// Normal operation requires exactly 2 arguments: date and message
-	if len(c.Args) != 2 {
-		return NewMissingArgumentsError(2, len(c.Args))
+	if len(c.Args) != RequiredArguments {
+		return NewMissingArgumentsError(RequiredArguments, len(c.Args))
 	}
 
 	return nil
@@ -47,7 +52,7 @@ func (c *Config) GetDate() string {
 
 // GetMessage returns the commit message argument.
 func (c *Config) GetMessage() string {
-	if len(c.Args) >= 2 {
+	if len(c.Args) >= RequiredArguments {
 		return c.Args[1]
 	}
 	return ""

internal/cli/errors.go

@@ -20,26 +20,16 @@ type UserError struct {
 	Hint    string
 }
 
-// Error implements the error interface.
-func (e *UserError) Error() string {
-	if e.Details != "" && e.Hint != "" {
-		return fmt.Sprintf("Error: %s\n\n%s\n\n%s", e.Message, e.Details, e.Hint)
-	}
-	if e.Details != "" {
-		return fmt.Sprintf("Error: %s\n\n%s", e.Message, e.Details)
-	}
-	if e.Hint != "" {
-		return fmt.Sprintf("Error: %s\n\n%s", e.Message, e.Hint)
-	}
-	return fmt.Sprintf("Error: %s", e.Message)
-}
-
 // NewInvalidDateFormatError creates an error for invalid date format.
 func NewInvalidDateFormatError(provided string) *UserError {
 	return &UserError{
 		Type:    "InvalidDateFormat",
 		Message: "Invalid date format",
-		Details: fmt.Sprintf("Expected format: YYYY-MM-DD HH:MM:SS\nExample:         2025-02-05 20:19:19\n\nYou provided:    %s", provided),
+		Details: fmt.Sprintf(
+			"Expected format: YYYY-MM-DD HH:MM:SS\nExample:         2025-02-05 20:19:19\n\n"+
+				"You provided:    %s",
+			provided,
+		),
 	}
 }
 
@@ -58,7 +48,8 @@ func NewNoRepositoryError() *UserError {
 		Type:    "NoRepository",
 		Message: "Not a Git repository",
 		Details: "The current directory is not inside a Git repository.",
-		Hint:    "To fix this:\n  - Navigate to a Git repository: cd /path/to/repo\n  - Or initialize a new repository: git init",
+		Hint: "To fix this:\n  - Navigate to a Git repository: cd /path/to/repo\n" +
+			"  - Or initialize a new repository: git init",
 	}
 }
 
@@ -68,7 +59,8 @@ func NewChronologyViolationError(providedDate, lastCommitDate string, equal bool
 	hint := "Commits must be dated after the last commit to maintain chronological order."
 
 	if equal {
-		hint = "Commits must be dated AFTER the last commit (not equal).\nSuggestion: Try adding 1 second to your date."
+		hint = "Commits must be dated AFTER the last commit (not equal).\n" +
+			"Suggestion: Try adding 1 second to your date."
 	}
 
 	return &UserError{
@@ -84,8 +76,9 @@ func NewGitCommandError(gitError string) *UserError {
 	return &UserError{
 		Type:    "GitCommandError",
 		Message: "Git commit failed",
-		Details: fmt.Sprintf("Git error: %s", gitError),
-		Hint:    "Possible solutions:\n  - Stage your changes: git add <files>\n  - Check if changes exist: git status",
+		Details: "Git error: " + gitError,
+		Hint: "Possible solutions:\n  - Stage your changes: git add <files>\n" +
+			"  - Check if changes exist: git status",
 	}
 }
 
@@ -94,7 +87,28 @@ func NewMissingArgumentsError(expected, received int) *UserError {
 	return &UserError{
 		Type:    "MissingArguments",
 		Message: "Missing required arguments",
-		Details: fmt.Sprintf("Usage: gitcommit <date> <message>\n\nExpected: %d arguments\nReceived: %d argument(s)", expected, received),
-		Hint:    "Examples:\n  gitcommit \"2025-02-05 20:19:19\" \"Add new feature\"\n  gitcommit \"2025-12-31 23:59:59\" \"End of year commit\"\n\nRun 'gitcommit --help' for more information.",
+		Details: fmt.Sprintf(
+			"Usage: gitcommit <date> <message>\n\nExpected: %d arguments\nReceived: %d argument(s)",
+			expected,
+			received,
+		),
+		Hint: "Examples:\n" +
+			"  gitcommit \"2025-02-05 20:19:19\" \"Add new feature\"\n" +
+			"  gitcommit \"2025-12-31 23:59:59\" \"End of year commit\"\n\n" +
+			"Run 'gitcommit --help' for more information.",
+	}
+}
+
+// Error implements the error interface.
+func (e *UserError) Error() string {
+	if e.Details != "" && e.Hint != "" {
+		return "Error: " + e.Message + "\n\n" + e.Details + "\n\n" + e.Hint
+	}
+	if e.Details != "" {
+		return "Error: " + e.Message + "\n\n" + e.Details
+	}
+	if e.Hint != "" {
+		return "Error: " + e.Message + "\n\n" + e.Hint
 	}
+	return "Error: " + e.Message
 }

internal/cli/help.go

@@ -1,10 +1,8 @@
 package cli
 
-import "fmt"
-
 // HelpText returns the formatted help text for the gitcommit tool.
 func HelpText() string {
-	return fmt.Sprintf(`gitcommit - Create Git commits with custom dates
+	return `gitcommit - Create Git commits with custom dates
 
 Usage:
   gitcommit <date> <message>
@@ -60,5 +58,5 @@ Error Messages:
 
 For more information, visit:
   https://github.com/sgaunet/gitcommit
-`)
+`
 }

internal/cli/messages.go

@@ -1,8 +1,6 @@
 package cli
 
-import "fmt"
-
 // FormatSuccessMessage formats a success message with a checkmark.
 func FormatSuccessMessage(gitFormattedDate string) string {
-	return fmt.Sprintf("✓ Commit created with date: %s", gitFormattedDate)
+	return "✓ Commit created with date: " + gitFormattedDate
 }

internal/datetime/constants.go

@@ -1,14 +1,15 @@
+// Package datetime provides date parsing, validation, and formatting utilities for gitcommit.
 package datetime
 
 import "time"
 
 const (
 	// InputDateLayout is the format users provide for commit dates.
-	// Example: "2025-02-05 20:19:19"
+	// Example: "2025-02-05 20:19:19".
 	InputDateLayout = "2006-01-02 15:04:05"
 
 	// GitDateLayout is the format Git expects for GIT_AUTHOR_DATE and GIT_COMMITTER_DATE environment variables.
-	// Example: "Wed 5 Feb 2025 20:19:19 CEST"
+	// Example: "Wed 5 Feb 2025 20:19:19 CEST".
 	GitDateLayout = "Mon 2 Jan 2006 15:04:05 MST"
 
 	// GitLogDateLayout is the format git log returns when using --format=%cI (ISO 8601).

internal/datetime/parser.go

@@ -1,10 +1,16 @@
 package datetime
 
 import (
+	"errors"
 	"fmt"
 	"time"
 )
 
+var (
+	// ErrInvalidCalendarDate is returned when a date doesn't exist in the calendar.
+	ErrInvalidCalendarDate = errors.New("invalid calendar date")
+)
+
 // ParseDate parses a date string in the format "YYYY-MM-DD HH:MM:SS" and returns a time.Time.
 // The date is parsed in the local timezone.
 //
@@ -22,7 +28,7 @@ func ParseDate(dateStr string) (time.Time, error) {
 	// This catches cases like "2025-02-30" which might parse but be invalid
 	formatted := parsedTime.Format(InputDateLayout)
 	if formatted != dateStr {
-		return time.Time{}, fmt.Errorf("invalid calendar date %q", dateStr)
+		return time.Time{}, fmt.Errorf("%w: %q", ErrInvalidCalendarDate, dateStr)
 	}
 
 	return parsedTime, nil

internal/datetime/validator.go

@@ -31,11 +31,11 @@ type ValidationResult struct {
 //   - lastCommitDate: The date of the last commit (nil if no previous commits)
 //
 // Returns:
-//   - valid: true if the date is valid, false otherwise
-//   - errorType: empty string if valid, or one of:
+//   - bool: true if the date is valid, false otherwise
+//   - string: empty string if valid, or one of:
 //   - "chronology_violation": date is before last commit
 //   - "chronology_violation_equal": date is equal to last commit
-func ValidateChronology(commitDate time.Time, lastCommitDate *time.Time) (valid bool, errorType string) {
+func ValidateChronology(commitDate time.Time, lastCommitDate *time.Time) (bool, string) {
 	// If there's no last commit, any date is valid
 	if lastCommitDate == nil {
 		return true, ""