fix: version injection

fix: version injection

Author: sgaunet

.golangci.yml

@@ -20,3 +20,5 @@ linters:
     - noinlineerr
     # Intentionally using time.Local for user's local timezone
     - gosmopolitan
+    # strings.SplitSeq doesn't exist in Go 1.21
+    - modernize

cmd/gitcommit/main.go

@@ -10,6 +10,9 @@ import (
 	"github.com/sgaunet/gitcommit/internal/cli"
 )
 
+// version is set via ldflags during build.
+var version = "dev"
+
 func main() {
 	// Setup structured logging with slog
 	logger := slog.New(slog.NewTextHandler(os.Stderr, &slog.HandlerOptions{
@@ -18,7 +21,7 @@ func main() {
 	slog.SetDefault(logger)
 
 	// Create configuration
-	config := cli.NewConfig()
+	config := cli.NewConfig(version)
 
 	// Parse command-line flags
 	flag.BoolVar(&config.ShowHelp, "help", false, "Show help message")
@@ -32,7 +35,7 @@ func main() {
 
 	// Handle --version flag
 	if config.ShowVersion {
-		fmt.Printf("gitcommit version %s\n", config.Version)
+		fmt.Printf("%s\n", config.Version)
 		os.Exit(cli.ExitSuccess)
 	}
 

go.mod

@@ -1,3 +1,3 @@
 module github.com/sgaunet/gitcommit
 
-go 1.25.4
+go 1.25

internal/cli/config.go

@@ -20,10 +20,14 @@ type Config struct {
 	Args []string
 }
 
-// NewConfig creates a new Config with default values.
-func NewConfig() *Config {
+// NewConfig creates a new Config with the specified version.
+func NewConfig(version string) *Config {
+	// If version is empty, use a default
+	if version == "" {
+		version = "dev"
+	}
 	return &Config{
-		Version: "1.0.0",
+		Version: version,
 	}
 }
 

tests/integration/cli_args_test.go

@@ -81,9 +81,15 @@ func TestVersionFlag(t *testing.T) {
 				t.Fatalf("Version flag should not error: %v\nOutput: %s", err, output)
 			}
 
-			expected := "gitcommit version 1.0.0"
-			if !strings.Contains(string(output), expected) {
-				t.Errorf("Expected output containing %q, got: %s", expected, output)
+			// Check that version output is not empty
+			outputStr := strings.TrimSpace(string(output))
+			if outputStr == "" {
+				t.Errorf("Expected version output, got empty string")
+			}
+
+			// Version should be "dev" during testing or a semver string when built
+			if outputStr != "dev" && !strings.Contains(outputStr, ".") {
+				t.Errorf("Expected valid version output (dev or semver), got: %s", outputStr)
 			}
 		})
 	}