Skip to content

Commit 11c0a5f

Browse files
committed
Fix code for filtering with sel by calling compute.
1 parent c76728f commit 11c0a5f

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

docs/examples/gwas_tutorial.ipynb

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5904,7 +5904,7 @@
59045904
}
59055905
],
59065906
"source": [
5907-
"ds = ds.sel(samples=((ds.sample_dp_mean >= 4) & (ds.sample_call_rate >= 0.97)))\n",
5907+
"ds = ds.sel(samples=((ds.sample_dp_mean >= 4) & (ds.sample_call_rate >= 0.97)).compute())\n",
59085908
"print(f\"After filter, {len(ds.samples)}/284 samples remain.\")"
59095909
]
59105910
},
@@ -9219,7 +9219,7 @@
92199219
"metadata": {},
92209220
"outputs": [],
92219221
"source": [
9222-
"ds = ds.sel(variants=((ds.variant_allele_frequency[:,1] > 0.01) & (ds.variant_hwe_p_value > 1e-6)))"
9222+
"ds = ds.sel(variants=((ds.variant_allele_frequency[:,1] > 0.01) & (ds.variant_hwe_p_value > 1e-6)).compute())"
92239223
]
92249224
},
92259225
{
@@ -11181,8 +11181,8 @@
1118111181
"source": [
1118211182
"# To run PCA we need to filter out variants with any missing alt allele counts\n",
1118311183
"# Or where the counts are zero for all samples\n",
11184-
"variant_mask = ((ds_pca.call_alternate_allele_count < 0).any(dim=\"samples\")) | \\\n",
11185-
" (ds_pca.call_alternate_allele_count.std(dim=\"samples\") <= 0.0)\n",
11184+
"variant_mask = (((ds_pca.call_alternate_allele_count < 0).any(dim=\"samples\")) | \\\n",
11185+
" (ds_pca.call_alternate_allele_count.std(dim=\"samples\") <= 0.0)).compute()\n",
1118611186
"ds_pca = ds_pca.sel(variants=~variant_mask)"
1118711187
]
1118811188
},

docs/how_do_i.rst

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -135,11 +135,11 @@ Call :meth:`xarray.Dataset.sel` on the ``variants`` dimension:
135135
.. ipython:: python
136136
137137
ds2 = sg.hardy_weinberg_test(ds)
138-
ds2.sel(variants=(ds2.variant_hwe_p_value > 1e-2))
138+
ds2.sel(variants=(ds2.variant_hwe_p_value > 1e-2).compute())
139139
140140
.. note::
141141

142-
Filtering causes an eager Xarray computation.
142+
The call to ``compute`` is needed to avoid an Xarray error.
143143

144144
Find which new variables were added by a method?
145145
------------------------------------------------

0 commit comments

Comments
 (0)