-
Notifications
You must be signed in to change notification settings - Fork 38
Description
Hi sgkit community, I want to more actively maintain this toolkit and would like to start by fixing the CI. I’ve fixed some issues, but there are a few points I’m not sure about and would like feedback.
What I’ve done
-
Pinned pandas < 3.0 to fix CI.
Dask is not fully supported with pandas 3.0 yet, so this is likely a temporary pin until the ecosystem stabilizes. -
Apple M4 + NumPy:
On Apple M4 chips, NumPy < 2.3.5 can emit runtime warnings in matmul.
I split NumPy constraints because:- Python 3.10 compatibility only works with NumPy < 2.3.0
- Apple M4 issue is resolved by numpy >= 2.3.5
Reference:
BUG: "divide by zero encountered in matmul" on MacOS M4 with numpy v2.3.3 numpy/numpy#29820
ENH: Make FPE blas check a runtime check for all apple arm systems numpy/numpy#30102
https://numpy.org/doc/stable/release/2.3.0-notes.html -
xarray xr.concat FutureWarning (data_vars=None default change)
I made the test explicit with data_vars="all".
Reference:Stricter defaults for concat, combine, open_mfdataset, merge pydata/xarray#8778
New defaults forconcat,merge,combine_*pydata/xarray#10062 -
Zarr error regex update
Updated the regex to match the new “contains data” wording in Zarr v3.
Reference:https://zarr.readthedocs.io/en/v3.0.9/_modules/zarr/storage/_common.html
Questions:
-
Based on the NumPy/Python support tables, are we planning to drop Python 3.10 and NumPy < 2 soon?
Reference:https://devguide.python.org/versions/#supported-versions
https://numpy.org/neps/nep-0029-deprecation_policy.html#support-table
https://numpy.org/neps/nep-0029-deprecation_policy.html#drop-schedule -
How should we handle warnings in CI for Zarr > 3 (ignore in tests vs. require code changes)?