Skip to content

Commit 23d8734

Browse files
committed
Unpin numpy and run tests on numpy 1 and 2
1 parent d152af1 commit 23d8734

File tree

2 files changed

+28
-1
lines changed

2 files changed

+28
-1
lines changed

.github/workflows/ci.yml

Lines changed: 27 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -139,3 +139,30 @@ jobs:
139139
cd tests
140140
python -m vcztools --help
141141
142+
test-numpy-version:
143+
name: Test numpy versions
144+
runs-on: ubuntu-latest
145+
strategy:
146+
matrix:
147+
numpy: ["==1.26", ">=2"]
148+
steps:
149+
- uses: actions/checkout@v4
150+
- name: Set up Miniconda
151+
uses: conda-incubator/setup-miniconda@v3
152+
with:
153+
auto-update-conda: true
154+
python-version: '3.11'
155+
channels: conda-forge,bioconda
156+
- name: Install dependencies
157+
run: |
158+
conda install bcftools
159+
python -m pip install --upgrade pip
160+
python -m pip install '.[dev]'
161+
# Build the extension module in-place so pytest can find it
162+
python3 setup.py build_ext --inplace
163+
- name: Install numpy${{ matrix.numpy }}
164+
run: |
165+
python -m pip install 'numpy${{ matrix.numpy }}'
166+
- name: Run tests
167+
run: |
168+
pytest

pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ authors = [
1111
{name = "sgkit Developers", email = "[email protected]"},
1212
]
1313
dependencies = [
14-
"numpy>=1.23.5,<2",
14+
"numpy>=1.23.5",
1515
"zarr>=2.17,<3",
1616
"click",
1717
"pyranges",

0 commit comments

Comments
 (0)