Skip to content

Commit 9f65778

Browse files
authored
fix: always use long commit sha in links (#24)
1 parent 1050274 commit 9f65778

File tree

4 files changed

+9
-5
lines changed

4 files changed

+9
-5
lines changed

dist/index.js

Lines changed: 2 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/index.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/__tests__/markdown.test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -90,8 +90,8 @@ test("markdown pr body for multiple submodules using tag strategy and previous c
9090
const submodules = [mdBook, nvim, vscodeIcons];
9191
const expected = `
9292
| --- | --- | --- |
93-
| [catppuccin/mdBook](https://github.com/catppuccin/mdBook.git) | ports/mdBook | [a19a19b...v2.2.0](https://github.com/catppuccin/mdBook/compare/a19a19b...v2.2.0) |
94-
| [catppuccin/nvim](https://github.com/catppuccin/nvim.git) | ports/nvim | [774a4ed...v1.9.0](https://github.com/catppuccin/nvim/compare/774a4ed...v1.9.0) |
93+
| [catppuccin/mdBook](https://github.com/catppuccin/mdBook.git) | ports/mdBook | [a19a19b...v2.2.0](https://github.com/catppuccin/mdBook/compare/a19a19bd14f26c3bba311bbffc5a74710add5ac2...v2.2.0) |
94+
| [catppuccin/nvim](https://github.com/catppuccin/nvim.git) | ports/nvim | [774a4ed...v1.9.0](https://github.com/catppuccin/nvim/compare/774a4ed9a69d0a2633da60f73aa63a8e23aacced...v1.9.0) |
9595
| [catppuccin/vscode-icons](https://github.com/catppuccin/vscode-icons.git) | ports/vscode-icons | [v1.14.0...v1.15.0](https://github.com/catppuccin/vscode-icons/compare/v1.14.0...v1.15.0) |
9696
`;
9797

src/markdown.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,14 +13,17 @@ const tableRow = (submodule: Submodule) => {
1313
const cleanUrl = submodule.url.replace(".git", "");
1414
let changeDisplay = `${submodule.previousShortCommitSha}...${submodule.latestShortCommitSha}`;
1515
let changeUrl = `[${changeDisplay}](${cleanUrl}/compare/${submodule.previousCommitSha}...${submodule.latestCommitSha})`;
16+
1617
if (submodule.latestTag) {
1718
if (submodule.previousCommitShaHasTag) {
1819
changeDisplay = `${submodule.previousTag}...${submodule.latestTag}`;
20+
changeUrl = `[${changeDisplay}](${cleanUrl}/compare/${changeDisplay})`;
1921
} else {
2022
changeDisplay = `${submodule.previousShortCommitSha}...${submodule.latestTag}`;
23+
changeUrl = `[${changeDisplay}](${cleanUrl}/compare/${submodule.previousCommitSha}...${submodule.latestTag})`;
2124
}
22-
changeUrl = `[${changeDisplay}](${cleanUrl}/compare/${changeDisplay})`;
2325
}
26+
2427
return `| ${name} | ${submodule.path} | ${changeUrl} |`;
2528
};
2629

0 commit comments

Comments
 (0)