TerminalFont: fix possible buffer overflow

CarterLi · CarterLi · commit 9ea887e841c4 · 2024-10-06T09:27:55.000+08:00
diff --git a/src/detection/terminalfont/terminalfont.c b/src/detection/terminalfont/terminalfont.c
@@ -82,7 +82,7 @@ FF_MAYBE_UNUSED static bool detectKitty(const FFstrbuf* exe, FFTerminalFontResul
     if (ffGetTerminalResponse(
         "\eP+q6b697474792d71756572792d666f6e745f66616d696c79;6b697474792d71756572792d666f6e745f73697a65\e\\", // kitty-query-font_family;kitty-query-font_size
         2,
-        "\eP1+r%*[^=]=%512[^\e]\e\\\eP1+r%*[^=]=%512[^\e]\e\\", fontHex, sizeHex) == NULL && *fontHex && *sizeHex)
+        "\eP1+r%*[^=]=%511[^\e]\e\\\eP1+r%*[^=]=%511[^\e]\e\\", fontHex, sizeHex) == NULL && *fontHex && *sizeHex)
     {
         // decode hex string
         for (const char* p = fontHex; p[0] && p[1]; p += 2)

Original file line number	Diff line number	Diff line change
`@@ -82,7 +82,7 @@ FF_MAYBE_UNUSED static bool detectKitty(const FFstrbuf* exe, FFTerminalFontResul`
`82`	`82`	`if (ffGetTerminalResponse(`
`83`	`83`	`"\eP+q6b697474792d71756572792d666f6e745f66616d696c79;6b697474792d71756572792d666f6e745f73697a65\e\\", // kitty-query-font_family;kitty-query-font_size`
`84`	`84`	`2,`
`85`		`- "\eP1+r%[^=]=%512[^\e]\e\\\eP1+r%[^=]=%512[^\e]\e\\", fontHex, sizeHex) == NULL && fontHex && sizeHex)`
	`85`	`+ "\eP1+r%[^=]=%511[^\e]\e\\\eP1+r%[^=]=%511[^\e]\e\\", fontHex, sizeHex) == NULL && fontHex && sizeHex)`
`86`	`86`	`{`
`87`	`87`	`// decode hex string`
`88`	`88`	`for (const char* p = fontHex; p[0] && p[1]; p += 2)`