Make the reading and writing of files less ugly

Author: belcar-s

src/commands/tests.sidebar.ts

@@ -60,14 +60,23 @@ export function registerRunAll(testsDataProvider: TestsDataProvider) {
       "state.json",
     );
 
-    function warningWasShown(path: string): boolean {
+    function readJSON(path: string) {
       try {
         const file = nova.fs.open(path) as FileTextMode;
-        const data = JSON.parse(file.readlines().join("\n"));
+        const content = JSON.parse(file.readlines().join("\n"));
         file.close();
-        return data.warningWasShown;
+        return content;
+      } catch {
+        return "";
+      }
+    }
+
+    function warningWasShown(path: string): boolean {
+      let content = readJSON(path);
+      let file;
+      try {
+        file = nova.fs.open(path, "w") as FileTextMode;
       } catch {
-        // I hope it's OK to create so many `File` objects.
         try {
           nova.fs.mkdir(nova.extension.workspaceStoragePath);
         } catch (e) {
@@ -76,12 +85,16 @@ export function registerRunAll(testsDataProvider: TestsDataProvider) {
             { cause: e },
           );
         }
-        nova.fs.open(path, "x").close();
-        const file = nova.fs.open(path, "w");
+        file = nova.fs.open(path, "w") as FileTextMode;
+      }
+
+      if (!content.length) {
         file.write(JSON.stringify({ warningWasShown: false }));
-        file.close();
-        return warningWasShown(path);
+        content = readJSON(path);
       }
+
+      const { warningWasShown } = content;
+      return !!warningWasShown;
     }
 
     if (!warningWasShown(hiddenWorkspaceDataPath)) {
@@ -101,12 +114,8 @@ export function registerRunAll(testsDataProvider: TestsDataProvider) {
         return;
       }
 
-      const oldFile = nova.fs.open(hiddenWorkspaceDataPath) as FileTextMode;
-      const data = JSON.parse(oldFile.readlines().join("\n"));
-      oldFile.close();
-      nova.fs.remove(hiddenWorkspaceDataPath);
-      nova.fs.open(hiddenWorkspaceDataPath, "x").close();
-      const file = nova.fs.open(hiddenWorkspaceDataPath, "w");
+      const file = nova.fs.open(hiddenWorkspaceDataPath, "rw") as FileTextMode;
+      const data = JSON.parse(file.readlines().join("\n"));
       data.warningWasShown = true;
       file.write(JSON.stringify(data));
       file.close();