Change abs_diff to duration_since, so it returns a Duration

Author: martinsaposnic

lightning-liquidity/src/lsps0/ser.rs

@@ -240,9 +240,10 @@ impl LSPSDateTime {
 		now_seconds_since_epoch > datetime_seconds_since_epoch
 	}
 
-	/// Returns the time in seconds since the unix epoch.
-	pub fn abs_diff(&self, other: &Self) -> u64 {
-		self.0.timestamp().abs_diff(other.0.timestamp())
+	/// Returns the absolute difference between two datetimes as a `Duration`.
+	pub fn duration_since(&self, other: &Self) -> Duration {
+		let diff_secs = self.0.timestamp().abs_diff(other.0.timestamp());
+		Duration::from_secs(diff_secs)
 	}
 
 	/// Returns the time in seconds since the unix epoch.

lightning-liquidity/src/lsps5/service.rs

@@ -156,7 +156,7 @@ where
 		let should_prune = {
 			let last_pruning = self.last_pruning.lock().unwrap();
 			last_pruning.as_ref().map_or(true, |last_time| {
-				now.abs_diff(&last_time) > PRUNE_STALE_WEBHOOKS_INTERVAL_DAYS.as_secs()
+				now.duration_since(&last_time) > PRUNE_STALE_WEBHOOKS_INTERVAL_DAYS
 			})
 		};
 
@@ -428,10 +428,8 @@ where
 				webhook
 					.last_notification_sent
 					.get(&notification.method)
-					.map(|last_sent| now.abs_diff(&last_sent))
-					.map_or(false, |duration| {
-						duration < DEFAULT_NOTIFICATION_COOLDOWN_HOURS.as_secs()
-					})
+					.map(|last_sent| now.duration_since(&last_sent))
+					.map_or(false, |duration| duration < DEFAULT_NOTIFICATION_COOLDOWN_HOURS)
 			});
 
 			if rate_limit_applies {
@@ -505,7 +503,7 @@ where
 		webhooks.retain(|client_id, client_webhooks| {
 			if !self.client_has_open_channel(client_id) {
 				client_webhooks.retain(|_, webhook| {
-					now.abs_diff(&webhook.last_used) < MIN_WEBHOOK_RETENTION_DAYS.as_secs()
+					now.duration_since(&webhook.last_used) < MIN_WEBHOOK_RETENTION_DAYS
 				});
 				!client_webhooks.is_empty()
 			} else {