Link in CommandItem

[NixBiks]

I just checked the source code for the documentation page, i.e. for the command-menu. It looks like this

<CommandItem
    key={navItem.href}
    value={navItem.title}
    onSelect={() => {
    runCommand(() => router.push(navItem.href as string))
    }}
>
    <FileIcon className="mr-2 h-4 w-4" />
    {navItem.title}
</CommandItem>

So for navigating we are using router.push instead of using Link from next/link. Isn't that suboptimal? I assume you'd prefer to have prefetching which comes for free with Link but is that even possible with CommandItem? Alternatively you can do router.prefetch I guess. See here for more details. I realise it isn't a big deal for this site (probably) but in other cases it might be.

[Yhozen]

👀

[Yhozen]

import Link from 'next/link';
import { CommandItem } from '@/components/ui/command';

export function CommandMenu() {
  return (
    <CommandItem asChild>
      <Link href="/dashboard">Dashboard</Link>
    </CommandItem>
  );
}

[fmarkulin]

This doesn't trigger the routing via the Enter key, which is the expected interaction with Command Dialog

[DanielRamosAcosta]

@fmarkulin did you solved this problem?