Skip to content

Conversation

@YogeshK34
Copy link

Summary

This PR removes an unnecessary <Label> from the Dialog Close Button example in
apps/v4/registry/new-york-v4/example/dialog-close-button.tsx.

The input inside the dialog is readOnly and not part of a form, so the label does not provide any additional accessibility or functional benefit. The dialog title (“Share link”) already provides sufficient context for screen readers.


Why

  1. The <Label> was not referenced visually or semantically.
  2. It does not improve accessibility in this scenario.
  3. It adds noise to the example and may confuse developers learning the component.
  4. Removing it simplifies the example without changing behavior.

What’s changed

// Removed:
// <Label htmlFor="link" className="sr-only">Link</Label>

No other logic or styles were modified.

@vercel
Copy link

vercel bot commented Nov 23, 2025

@YogeshK34 is attempting to deploy a commit to the shadcn-pro Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant