Update init method

Author: MUTOgen

lib/cypress_on_rails/vcr/insert_eject_middleware.rb

@@ -7,7 +7,8 @@ class InsertEjectMiddleware
       include MiddlewareHelpers
 
       def initialize(app, vcr = nil)
-        super(app, vcr)
+        @app = app
+        @vcr = vcr
         @first_call = false
       end
 
@@ -33,6 +34,8 @@ def handle_insert(req)
         cassette_name, options = extract_cassette_info(body)
         vcr.insert_cassette(cassette_name, options)
         [201, { 'Content-Type' => 'application/json' }, [{ 'message': 'OK' }.to_json]]
+      rescue JSON::ParserError => e
+        [400, { 'Content-Type' => 'application/json' }, [{ 'message': e.message }.to_json]]
       rescue LoadError, ArgumentError => e
         [500, { 'Content-Type' => 'application/json' }, [{ 'message': e.message }.to_json]]
       end

lib/cypress_on_rails/vcr/middleware_helpers.rb

@@ -6,11 +6,6 @@ module Vcr
     module MiddlewareHelpers
       include MiddlewareConfig
 
-      def initialize(app, vcr = nil)
-        @app = app
-        @vcr = vcr
-      end
-
       def vcr
         @vcr ||= configure_vcr
       end

lib/cypress_on_rails/vcr/use_cassette_middleware.rb

@@ -6,6 +6,11 @@ module Vcr
     class UseCassetteMiddleware
       include MiddlewareHelpers
 
+      def initialize(app, vcr = nil)
+        @app = app
+        @vcr = vcr
+      end
+
       def call(env)
         return @app.call(env) if should_not_use_vcr?
 

spec/cypress_on_rails/vcr/insert_eject_middleware_spec.rb

@@ -101,6 +101,16 @@ def rack_input(json_value)
                                    ])
           end
         end
+
+        it 'returns a 400 error when JSON parsing fails' do
+          env['rack.input'] = StringIO.new('invalid json')
+
+          expect(response).to eq([
+                                   400,
+                                   { 'Content-Type' => 'application/json' },
+                                   ['{"message":"unexpected token at \'invalid json\'"}']
+                                 ])
+        end
       end
 
       describe '/__e2e__/vcr/eject' do