-
-
Notifications
You must be signed in to change notification settings - Fork 62
Add simple release script (gem-only) #192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Removed `require 'bundler/gem_tasks'` from Rakefile because it creates a conflicting `release` task that shadows our custom release task in rakelib/release.rake. Added manual :build task to replace what bundler/gem_tasks provided. This matches the react_on_rails pattern where rakelib/release.rake provides the release task without conflicts. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Cleaned up release.rake to exactly match react_on_rails pattern but without the npm/release-it parts that aren't needed for cypress-on-rails. Removed from react_on_rails version: - npm_version conversion logic - release-it command execution - Gemfile.lock updates for dummy apps - gemspec cleanup for subdirectories - GitHub packages publishing Kept from react_on_rails version: - Same structure and flow - RaisingMessageHandler class - TaskHelpers include pattern - git pull --rebase - gem bump with -v flag (fixed from --version) - gem release to rubygems.org - Post-release CHANGELOG reminder 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
The build task was not needed: - gem release command handles building the gem - We don't need a separate build step - The default task can just run specs This makes the Rakefile cleaner and simpler.
|
Warning Rate limit exceeded@justin808 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 0 minutes and 19 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (3)
✨ Finishing touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Code Review: PR #192 - Add simple release script (gem-only)SummaryThis PR adds a clean release automation script for the gem. The implementation is well-structured and follows the react_on_rails pattern appropriately. Overall, this is a solid PR with good design decisions. Strengths
Potential Issues
Security Considerations
Performance Considerations
Test Coverage
Additional Suggestions
VerdictAPPROVED with minor suggestions This is a well-implemented release script that achieves its goals cleanly. The main suggestions are:
Great work on keeping this focused and matching the established patterns! |
Summary
Adds a clean, simple release script that matches the react_on_rails pattern but without npm/yarn parts.
Changes
--versionto-vflag (correct syntax)--fileflag to specify version file locationsh_in_dirto useDir.chdirinstead of subshellRelease Workflow
Test Results
✅ Dry run tested successfully:
This is a clean PR focused only on the release script functionality.
🤖 Generated with Claude Code