Fix Rails 8.1 compatibility issue (#202)

[justin808]

Summary

• Fixed NoMethodError: undefined method 'delegate_missing_to' error in Rails 8.1
• Added require 'active_support/core_ext/module/delegation' before requiring rails/railtie

Details

Rails 8.1.0's railties now uses delegate_missing_to in Rails::Initializable::Collection, which requires ActiveSupport's delegation extensions to be loaded first. Without this, the railtie spec fails with a NoMethodError.

Test plan

• Tests pass locally with bundle exec rake
• CI tests should now pass for Rails 8

🤖 Generated with Claude Code

Summary by CodeRabbit

• Chores
  • Updated internal dependencies to support module delegation functionality.

[coderabbitai]

Walkthrough

A single require statement for ActiveSupport's module delegation extension is added to the Railtie initialization file. This enables the use of the delegate method for module-level delegation within the codebase, with no functional or control flow modifications.

Changes

Cohort / File(s)	Summary
Dependency Addition lib/cypress_on_rails/railtie.rb	Added require for active_support/core_ext/module/delegation to enable module-level method delegation

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A delegate we now declare,
With ActiveSupport's helping care,
One tiny line, so light and neat,
Makes module magic now complete!
✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The pull request title "Fix Rails 8.1 compatibility issue (#202)" is clearly and directly related to the main change in the changeset. The PR addresses a specific Rails 8.1.0 compatibility issue where delegate_missing_to was raising a NoMethodError, and the fix adds the required ActiveSupport delegation extension. The title accurately describes the purpose and outcome of the change without being misleading or off-topic. While the title doesn't specify the exact implementation detail (adding a require statement), titles appropriately focus on what was fixed rather than implementation specifics, making this sufficiently descriptive for someone scanning commit history to understand the primary change.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch justin808/fix-rails-8-delegate-missing

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a1a7dd6 and 1180d9e.

📒 Files selected for processing (1)

• lib/cypress_on_rails/railtie.rb (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)

• GitHub Check: rails_6_1
• GitHub Check: rails_8
• GitHub Check: claude-review
• GitHub Check: rails_7_2

🔇 Additional comments (1)

lib/cypress_on_rails/railtie.rb (1)

1-1: Excellent fix for Rails 8.1 compatibility!

This require statement correctly addresses the delegate_missing_to issue in Rails 8.1 by ensuring ActiveSupport's delegation extensions are loaded before railties. The placement is appropriate and follows the standard pattern for Rails compatibility fixes.

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 RuboCop (1.81.1)

lib/cypress_on_rails/railtie.rb

Could not find gem 'rspec' in locally installed gems.
/usr/lib/ruby/3.1.0/bundler/resolver.rb:269:in block in verify_gemfile_dependencies_are_found!' /usr/lib/ruby/3.1.0/bundler/resolver.rb:252:in map!'
/usr/lib/ruby/3.1.0/bundler/resolver.rb:252:in verify_gemfile_dependencies_are_found!' /usr/lib/ruby/3.1.0/bundler/resolver.rb:48:in start'
/usr/lib/ruby/3.1.0/bundler/resolver.rb:23:in resolve' /usr/lib/ruby/3.1.0/bundler/definition.rb:269:in resolve'
/usr/lib/ruby/3.1.0/bundler/definition.rb:468:in materialize' /usr/lib/ruby/3.1.0/bundler/definition.rb:190:in specs'
/usr/lib/ruby/3.1.0/bundler/runtime.rb:85:in block in definition_method' /var/lib/gems/3.1.0/gems/rubocop-1.81.1/lib/rubocop/config_loader_resolver.rb:296:in gem_config_path'
/var/lib/gems/3.1.0/gems/rubocop-1.81.1/lib/rubocop/config_loader_resolver.rb:84:in block (2 levels) in resolve_inheritance_from_gems' /var/lib/gems/3.1.0/gems/rubocop-1.81.1/lib/rubocop/config_loader_resolver.rb:82:in reverse_each'
/var/l

... [truncated 270 characters] ...

fig_loader_resolver.rb:76:in resolve_inheritance_from_gems' /var/lib/gems/3.1.0/gems/rubocop-1.81.1/lib/rubocop/config_loader.rb:58:in load_file'
/var/lib/gems/3.1.0/gems/rubocop-1.81.1/lib/rubocop/config_store.rb:34:in options_config=' /var/lib/gems/3.1.0/gems/rubocop-1.81.1/lib/rubocop/config_store.rb:29:in apply_options!'
/var/lib/gems/3.1.0/gems/rubocop-1.81.1/lib/rubocop/cli.rb:167:in act_on_options' /var/lib/gems/3.1.0/gems/rubocop-1.81.1/lib/rubocop/cli.rb:49:in block in run'
/var/lib/gems/3.1.0/gems/rubocop-1.81.1/lib/rubocop/cli.rb:87:in profile_if_needed' /var/lib/gems/3.1.0/gems/rubocop-1.81.1/lib/rubocop/cli.rb:45:in run'
/var/lib/gems/3.1.0/gems/rubocop-1.81.1/exe/rubocop:15:in <top (required)>' /usr/local/bin/rubocop:25:in load'
/usr/local/bin/rubocop:25:in `

'

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[claude]

PR Review: Fix Rails 8.1 compatibility issue

Overview

This PR addresses a Rails 8.1 compatibility issue by adding a single line to require ActiveSupport's delegation extensions before loading the Rails railtie. The fix is minimal, targeted, and appropriate for the problem at hand.

Code Quality ✅

Strengths:

• Minimal and surgical fix: The single-line change is exactly what's needed - no over-engineering
• Correct placement: The require is added at the top of the file, before rails/railtie, which is the right order
• Good documentation: PR description clearly explains the root cause (Rails 8.1's use of delegate_missing_to in Rails::Initializable::Collection)

Best Practices:

• Follows Ruby conventions for require statements at the top of files
• No code style violations detected
• The fix is consistent with how other files in the codebase would handle similar issues

Potential Issues 🟢

No issues found:

• The change is safe and won't affect existing behavior
• Only loads what's needed (specific module delegation extension, not all of ActiveSupport)
• No breaking changes for older Rails versions - this require has been available since Rails 3.x

Performance ⚡

Impact: Negligible

• Adding one require statement has minimal performance impact
• The active_support/core_ext/module/delegation module is lightweight
• This code only runs once during Rails initialization, not on hot paths
• The module would likely be loaded anyway in most Rails applications

Security 🔒

No security concerns:

• Standard Rails/ActiveSupport library require - no external dependencies
• No user input handling or attack surface changes
• The delegation functionality being required is a well-established Rails component

Test Coverage ✅

Current coverage:

• Existing test in spec/cypress_on_rails/railtie_spec.rb:1 validates that the railtie can be required and initializers run
• The spec file itself requires the railtie (line 1), which means it will fail if the delegation dependency is missing
• PR description indicates tests pass locally with bundle exec rake

Recommendation:

• Current test coverage is adequate for this fix
• The test that failed (which prompted this fix) will now pass with the require added
• No additional tests needed as this is a dependency fix, not new functionality

Additional Observations

1. Rails version compatibility: This fix maintains backward compatibility while enabling Rails 8.1 support
2. Consistency: This is the only file in the lib directory that requires the delegation extension, which makes sense as it's the only file that directly requires rails/railtie
3. Alternative approaches: None needed - this is the standard Ruby/Rails way to handle such dependency issues

Recommendation: ✅ APPROVE

This is a clean, well-documented fix for a specific Rails 8.1 compatibility issue. The change is minimal, safe, and follows Ruby/Rails best practices. No concerns identified.

Suggested next steps:

• Merge once CI passes
• Consider documenting the minimum Rails version support if not already specified in README or gemspec

---

🤖 Review generated with Claude Code