try using methods

Author: Judahmeek

spec/system/add_new_comment_spec.rb

@@ -7,61 +7,61 @@
 describe "Add new comment" do
   context "when React Router", page: :main, js: true, type: :system do
     context "with Horizontal Form" do
-      include_examples "with Horizontal Form"
+      select_horizontal_form(page)
       include_examples "New Comment Submission", true
-      include_examples "Validation errors displaying"
+      check_errors(page)
     end
 
     context "with Inline Form" do
-      include_examples "with Inline Form"
+      select_inline_form(page)
       include_examples "New Comment Submission", true
-      include_examples "Validation errors displaying"
+      check_errors(page)
     end
 
     context "with Stacked Form" do
-      include_examples "with Stacked Form"
+      select_stacked_form(page)
       include_examples "New Comment Submission", true
-      include_examples "Validation errors displaying"
+      check_errors(page)
     end
   end
 
   context "when React/Redux", page: :react_demo, js: true, type: :system do
     context "with Horizontal Form" do
-      include_examples "with Horizontal Form"
+      select_horizontal_form(page)
       include_examples "New Comment Submission", true
-      include_examples "Validation errors displaying"
+      check_errors(page)
     end
 
     context "with Inline Form" do
-      include_examples "with Inline Form"
+      select_inline_form(page)
       include_examples "New Comment Submission", true
-      include_examples "Validation errors displaying"
+      check_errors(page)
     end
 
     context "with Stacked Form" do
-      include_examples "with Stacked Form"
+      select_stacked_form(page)
       include_examples "New Comment Submission", true
-      include_examples "Validation errors displaying"
+      check_errors(page)
     end
   end
 
   context "when simple page", page: :simple, js: true, type: :system do
     context "with Horizontal Form" do
-      include_examples "with Horizontal Form"
+      select_horizontal_form(page)
       include_examples "New Comment Submission", false
-      include_examples "Validation errors displaying"
+      check_errors(page)
     end
 
     context "with Inline Form" do
-      include_examples "with Inline Form"
+      select_inline_form(page)
       include_examples "New Comment Submission", false
-      include_examples "Validation errors displaying"
+      check_errors(page)
     end
 
     context "with the Stacked Form" do
-      include_examples "with Stacked Form"
+      select_stacked_form(page)
       include_examples "New Comment Submission", false
-      include_examples "Validation errors displaying"
+      check_errors(page)
     end
   end
 end

spec/system/edit_comment_spec.rb

@@ -13,7 +13,7 @@
       click_link "Edit", match: :first
       let(:edited_name) { "Abraham Lincoln" }
 
-      include_context "when Form Submitted", name: :edited_name
+      submit_form(name: :edited_name, text: "dude!")
       expect(page).to have_css(".comment", text: :edited_name)
       expect(page).to have_css("#notice", text: "Comment was successfully updated.")
     end

spec/system/shared/examples.rb

@@ -8,7 +8,7 @@
     let(:name) { "John Smith" }
     let(:text) { "Hello there!" }
 
-    include_context "Form Submitted", name: :name, text: :text
+    submit_form(name: :name, text: :text)
 
     scenario "when comment is added" do
       expect(page).to have_css(".js-comment-author", text: name)
@@ -36,60 +36,52 @@
   context "with iframe text" do
     let(:iframe_text) { '<iframe src="http://www.w3schools.com"></iframe>' }
 
-    include_context "Form Submitted", text: :iframe_text
+    submit_form(name: "", text: :iframe_text)
 
     scenario "doesn't add an iframe" do
       expect(page).not_to have_css("iframe")
     end
   end
 end
 
-shared_examples "Validation errors displaying" do
-  context "when the new comment is submitted with blank fields", blank_form_submitted: true do
-    scenario "validation errors displayed" do
-      expect(page).to have_content("Your comment was not saved!")
-      expect(page).to have_content("Author: can't be blank")
-      expect(page).to have_content("Text: can't be blank")
+def check_errors(page)
+  expect(page).to have_content("Your comment was not saved!")
+  expect(page).to have_content("Author: can't be blank")
+  expect(page).to have_content("Text: can't be blank")
 
-      # with a successful consequent comment submitted
-      # the validation warnings should disappear
-      fill_in "Your Name", with: "Some name"
-      fill_in "Say something using markdown...", with: "Some text"
-      click_button "Post"
+  # with a successful consequent comment submitted
+  # the validation warnings should disappear
+  fill_in "Your Name", with: "Some name"
+  fill_in "Say something using markdown...", with: "Some text"
+  click_button "Post"
 
-      expect(page).to have_no_content("Your comment was not saved!")
-      expect(page).to have_no_content("Author: can't be blank")
-      expect(page).to have_no_content("Text: can't be blank")
-    end
-  end
+  expect(page).to have_no_content("Your comment was not saved!")
+  expect(page).to have_no_content("Author: can't be blank")
+  expect(page).to have_no_content("Text: can't be blank")
 end
 
 # Forms
-shared_examples "with Inline Form" do
+def select_inline_form(page)
   click_link "Inline Form"
   expect(page).to have_css("form.commentForm.form-inline")
 end
-shared_examples "with Stacked Form" do
+def select_stacked_form(page)
   click_link "Stacked Form"
   expect(page).to have_css("form.commentForm.form-stacked")
 end
-shared_examples "with Horizontal Form" do
-  include_examples "with Inline Form"
+def select_horizontal_form(page)
+  select_inline_form(page)
   click_link "Horizontal Form"
   expect(page).to have_css("form.commentForm.form-horizontal")
 end
 
 # Form Submission
-shared_examples "when Form Submitted", form_submitted: true do |name: "Spicoli", text: "dude!"|
+def submit_form(name: "Spicoli", text: "dude!")
   fill_in "Your Name", with: name
   fill_in "Say something using markdown...", with: text
   click_button "Post"
 end
 
-shared_examples "when Form Submitted with Blank Fields", blank_form_submitted: true do
-  include_context "Form Submitted", name: "", text: ""
-end
-
 shared_examples "when from classic page" do
   click_link "New Comment"