Skip to content

Commit 4df5be0

Browse files
justin808claude
andcommitted
Address CodeRabbit review feedback
- Move Rails environment loading inside run_precompile_tasks to improve startup time for help/kill commands (saves 1-3 seconds) - Remove unused HMR=true from Procfile.dev wp-server process (webpack config only checks WEBPACK_DEV_SERVER, not HMR env var) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
1 parent b20ef27 commit 4df5be0

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

Procfile.dev

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,4 +11,4 @@ rails: bundle exec thrust bin/rails server -p 3000
1111
# Client webpack dev server with HMR
1212
wp-client: RAILS_ENV=development NODE_ENV=development bin/shakapacker-dev-server
1313
# Server webpack watcher for SSR bundle
14-
wp-server: HMR=true SERVER_BUNDLE_ONLY=yes bin/shakapacker --watch
14+
wp-server: SERVER_BUNDLE_ONLY=yes bin/shakapacker --watch

bin/dev

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,11 +26,13 @@
2626

2727
require "bundler/setup"
2828
require "react_on_rails/dev"
29-
require_relative "../config/environment"
3029

3130
# Run precompile tasks before starting development server
3231
# This ensures rescript and locale files are generated before webpack starts
3332
def run_precompile_tasks
33+
# Load Rails environment only when needed (saves 1-3s for help/kill commands)
34+
require_relative "../config/environment"
35+
3436
puts "📦 Running precompile tasks..."
3537

3638
# Build ReScript files first

0 commit comments

Comments
 (0)