Skip to content

Commit 9042c4a

Browse files
justin808claude
andcommitted
Clean up configuration and remove duplicate code
- Add Chrome debug scripts to .gitignore - Improve bin/dev ReScript build error output with detailed messages - Disable early_hints debug mode in production (exposes internals) - Remove duplicate infer_spec_type_from_file_location! call in rails_helper 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
1 parent 3ba2fa7 commit 9042c4a

File tree

4 files changed

+9
-17
lines changed

4 files changed

+9
-17
lines changed

.gitignore

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -67,3 +67,7 @@ client/app/bundles/comments/rescript/**/*.bs.js
6767

6868
.claude/
6969
.context/
70+
71+
# Chrome DevTools debug scripts (development-only)
72+
check_early_hints.js
73+
check_early_hints.py

bin/dev

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,11 +35,13 @@ def run_precompile_tasks
3535

3636
# Build ReScript files first
3737
print " ReScript build... "
38-
if system("yarn res:build > /dev/null 2>&1")
38+
output = `yarn res:build 2>&1`
39+
if $?.success?
3940
puts "✅"
4041
else
4142
puts "❌"
42-
puts " Failed to build ReScript files. Run 'yarn res:build' to see errors."
43+
puts " Failed to build ReScript files:"
44+
output.each_line { |line| puts " #{line}" }
4345
exit 1
4446
end
4547

config/shakapacker.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,4 +72,4 @@ production:
7272
# Early hints configuration
7373
early_hints:
7474
enabled: true
75-
debug: true # Set to true to output debug info as HTML comments
75+
debug: false # Set to true to output debug info as HTML comments (exposes internals)

spec/rails_helper.rb

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -89,20 +89,6 @@
8989
Capybara.reset_sessions!
9090
end
9191

92-
# RSpec Rails can automatically mix in different behaviours to your tests
93-
# based on their file location, for example enabling you to call `get` and
94-
# `post` in specs under `spec/controllers`.
95-
#
96-
# You can disable this behaviour by removing the line below, and instead
97-
# explicitly tag your specs with their type, e.g.:
98-
#
99-
# RSpec.describe UsersController, :type => :controller do
100-
# # ...
101-
# end
102-
#
103-
# The different available types are documented in the features, such as in
104-
# https://relishapp.com/rspec/rspec-rails/docs
105-
config.infer_spec_type_from_file_location!
10692
config.include Capybara::DSL
10793

10894
# This will insert a <base> tag with the asset host into the pages created by

0 commit comments

Comments
 (0)