looks like contexts can no longer contain both actions & expectations

Author: Judahmeek

spec/system/add_new_comment_spec.rb

@@ -1,67 +1,78 @@
 # frozen_string_literal: true
 
 require "rails_helper"
-require "system/shared/examples"
 require "system/shared/contexts"
 
 describe "Add new comment" do
   context "when React Router", page: :main, js: true, type: :system do
-    context "with Horizontal Form" do
-      include_examples "with Horizontal Form"
-      include_examples "New Comment Submission", true
-      include_examples "Validation errors displaying"
+    it "with Horizontal Form" do
+      click_link "Inline Form"
+      click_link "Horizontal Form"
+      submit_form
+      include_examples "check if comment is added", true
+      include_examples "expect successful validation"
     end
 
-    context "with Inline Form" do
-      include_examples "with Inline Form"
-      include_examples "New Comment Submission", true
-      include_examples "Validation errors displaying"
+    it "with Inline Form" do
+      click_link "Inline Form"
+      submit_form
+      include_examples "check if comment is added", true
+      include_examples "expect successful validation"
     end
 
-    context "with Stacked Form" do
-      include_examples "with Stacked Form"
-      include_examples "New Comment Submission", true
-      include_examples "Validation errors displaying"
+    it "with Stacked Form" do
+      click_link "Stacked Form"
+      submit_form
+      include_examples "check if comment is added", true
+      include_examples "expect successful validation"
     end
   end
 
   context "when React/Redux", page: :react_demo, js: true, type: :system do
-    context "with Horizontal Form" do
-      include_examples "with Horizontal Form"
-      include_examples "New Comment Submission", true
-      include_examples "Validation errors displaying"
+    it "with Horizontal Form" do
+      click_link "Inline Form"
+      click_link "Horizontal Form"
+      submit_form
+      include_examples "check if comment is added", true
+      include_examples "expect successful validation"
     end
 
-    context "with Inline Form" do
-      include_examples "with Inline Form"
-      include_examples "New Comment Submission", true
-      include_examples "Validation errors displaying"
+    it "with Inline Form" do
+      click_link "Inline Form"
+      submit_form
+      include_examples "check if comment is added", true
+      include_examples "expect successful validation"
     end
 
-    context "with Stacked Form" do
-      include_examples "with Stacked Form"
-      include_examples "New Comment Submission", true
-      include_examples "Validation errors displaying"
+    it "with Stacked Form" do
+      click_link "Stacked Form"
+      submit_form
+      include_examples "check if comment is added", true
+      include_examples "expect successful validation"
     end
   end
 
   context "when simple page", page: :simple, js: true, type: :system do
-    context "with Horizontal Form" do
-      include_examples "with Horizontal Form"
-      include_examples "New Comment Submission", false
-      include_examples "Validation errors displaying"
+    it "with Horizontal Form" do
+      click_link "Inline Form"
+      click_link "Horizontal Form"
+      submit_form
+      include_examples "check if comment is added", false
+      include_examples "expect successful validation"
     end
 
-    context "with Inline Form" do
-      include_examples "with Inline Form"
-      include_examples "New Comment Submission", false
-      include_examples "Validation errors displaying"
+    it "with Inline Form" do
+      click_link "Inline Form"
+      submit_form
+      include_examples "check if comment is added", false
+      include_examples "expect successful validation"
     end
 
-    context "with the Stacked Form" do
-      include_examples "with Stacked Form"
-      include_examples "New Comment Submission", false
-      include_examples "Validation errors displaying"
+    it "with the Stacked Form" do
+      click_link "Stacked Form"
+      submit_form
+      include_examples "check if comment is added", false
+      include_examples "expect successful validation"
     end
   end
 end

spec/system/destroy_comment_spec.rb

@@ -8,10 +8,13 @@
     let(:comment) { Comment.first }
 
     it "clicking destroy link destroys comment" do
-      include_examples "when from classic page"
+      click_link "New Comment"
+      submit_form(name: comment.author, text: comment.text)
+
       accept_confirm do
         click_link "Destroy", href: comment_path(comment)
       end
+
       expect(page).not_to have_css(".comment", text: comment.author)
       expect(page).not_to have_css(".comment", text: comment.text)
     end

spec/system/edit_comment_spec.rb

@@ -1,26 +1,31 @@
 # frozen_string_literal: true
 
 require "rails_helper"
-require "system/shared/examples"
 require "system/shared/contexts"
 
 describe "Edit a comment", existing_comment: true do
   let(:comment) { Comment.first }
 
   context "when from classic page" do
     it "comment is updated when edit is submitted" do
-      include_examples "when from classic page"
+      click_link "New Comment"
+      submit_form
+
       click_link "Edit", match: :first
       let(:edited_name) { "Abraham Lincoln" }
 
-      include_context "when Form Submitted", name: :edited_name
+      subit_form(name: :edited_name)
       expect(page).to have_css(".comment", text: :edited_name)
       expect(page).to have_css("#notice", text: "Comment was successfully updated.")
     end
 
     it "comment is not updated when edit is submitted with blank fields", blank_form_submitted: true do
-      include_examples "when from classic page"
+      click_link "New Comment"
+      submit_form
+
       click_link "Edit", match: :first
+      submit_form(name: "", text: "")
+
       expect(page).not_to have_success_message
       expect(page).to have_failure_message
       expect(page).not_to have_css(".comment", text: "")

spec/system/shared/contexts.rb

@@ -20,3 +20,32 @@
 shared_context "when Existing Comment", existing_comment: true do
   before { Comment.create(author: "John Doe", text: "Hello there!") }
 end
+
+shared_examples "check if comment is added" do |expect_comment_count|
+  expect(page).to have_css(".js-comment-author", text: name)
+  expect(page).to have_css(".js-comment-text", text: text)
+  expect(page).to have_no_content("Your comment was not saved!")
+  if expect_comment_count
+    expect(page).to have_css("#js-comment-count",
+                             text: "Comments: #{Comment.count}")
+  end
+end
+
+shared_examples "expect failed validation" do
+  expect(page).to have_content("Your comment was not saved!")
+  expect(page).to have_content("Author: can't be blank")
+  expect(page).to have_content("Text: can't be blank")
+end
+
+shared_examples "expect successful validation" do
+  expect(page).to have_no_content("Your comment was not saved!")
+  expect(page).to have_no_content("Author: can't be blank")
+  expect(page).to have_no_content("Text: can't be blank")
+end
+
+# Form Submission
+def submit_form(name: "Spicoli", text: "dude!")
+  fill_in "Your Name", with: name
+  fill_in "Say something using markdown...", with: text
+  click_button "Post"
+end