Address alexeyr-ci2 PR review suggestions

- Remove unnecessary type annotations from TypeScript templates (useState<string>, React.ChangeEvent)
- Improve tsconfig.json settings:
  - Change moduleResolution from 'node' to 'bundler'
  - Remove unnecessary lib array (use defaults)
  - Remove exclude array (node_modules excluded by default)
  - Remove esModuleInterop and allowSyntheticDefaultImports
  - Add noUncheckedIndexedAccess for better type safety
  - Add check for existing tsconfig.json before creating
- Add component_extension helper method to GeneratorHelper
- Update generators to use component_extension helper consistently
- Improve Redux generator to use %W syntax for file arrays
- Fix line length issues in generator files

Addresses all unresolved suggestions from alexeyr-ci2's code review.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>

Author: justin808

lib/generators/react_on_rails/generator_helper.rb

@@ -91,4 +91,8 @@ def copy_file_and_missing_parent_directories(source_file, destination_file = nil
   def add_documentation_reference(message, source)
     "#{message} \n#{source}"
   end
+
+  def component_extension(options)
+    options.typescript? ? "tsx" : "jsx"
+  end
 end

lib/generators/react_on_rails/install_generator.rb

@@ -380,13 +380,16 @@ def create_css_module_types
       end
 
       def create_typescript_config
+        if File.exist?("tsconfig.json")
+          puts Rainbow("⚠️  tsconfig.json already exists, skipping creation").yellow
+          return
+        end
+
         tsconfig_content = {
           "compilerOptions" => {
             "target" => "es2018",
             "allowJs" => true,
             "skipLibCheck" => true,
-            "esModuleInterop" => true,
-            "allowSyntheticDefaultImports" => true,
             "strict" => true,
             "noUncheckedIndexedAccess" => true,
             "forceConsistentCasingInFileNames" => true,

lib/generators/react_on_rails/react_no_redux_generator.rb

@@ -18,12 +18,11 @@ class ReactNoReduxGenerator < Rails::Generators::Base
 
       def copy_base_files
         base_js_path = "base/base"
-        extension = options.typescript? ? "tsx" : "jsx"
 
         # Determine which component files to copy based on TypeScript option
         component_files = [
-          "app/javascript/src/HelloWorld/ror_components/HelloWorld.client.#{extension}",
-          "app/javascript/src/HelloWorld/ror_components/HelloWorld.server.#{extension}",
+          "app/javascript/src/HelloWorld/ror_components/HelloWorld.client.#{component_extension(options)}",
+          "app/javascript/src/HelloWorld/ror_components/HelloWorld.server.#{component_extension(options)}",
           "app/javascript/src/HelloWorld/ror_components/HelloWorld.module.css"
         ]
 

lib/generators/react_on_rails/react_with_redux_generator.rb

@@ -28,41 +28,37 @@ def create_redux_directories
 
       def copy_base_files
         base_js_path = "redux/base"
-        extension = options.typescript? ? "tsx" : "jsx"
+        ext = component_extension(options)
 
         # Copy Redux-connected component to auto-registration structure
-        copy_file("#{base_js_path}/app/javascript/bundles/HelloWorld/startup/HelloWorldApp.client.#{extension}",
-                  "app/javascript/src/HelloWorldApp/ror_components/HelloWorldApp.client.#{extension}")
-        copy_file("#{base_js_path}/app/javascript/bundles/HelloWorld/startup/HelloWorldApp.server.#{extension}",
-                  "app/javascript/src/HelloWorldApp/ror_components/HelloWorldApp.server.#{extension}")
+        copy_file("#{base_js_path}/app/javascript/bundles/HelloWorld/startup/HelloWorldApp.client.#{ext}",
+                  "app/javascript/src/HelloWorldApp/ror_components/HelloWorldApp.client.#{ext}")
+        copy_file("#{base_js_path}/app/javascript/bundles/HelloWorld/startup/HelloWorldApp.server.#{ext}",
+                  "app/javascript/src/HelloWorldApp/ror_components/HelloWorldApp.server.#{ext}")
         copy_file("#{base_js_path}/app/javascript/bundles/HelloWorld/components/HelloWorld.module.css",
                   "app/javascript/src/HelloWorldApp/components/HelloWorld.module.css")
 
         # Update import paths in client component
-        ror_client_file = "app/javascript/src/HelloWorldApp/ror_components/HelloWorldApp.client.#{extension}"
+        ror_client_file = "app/javascript/src/HelloWorldApp/ror_components/HelloWorldApp.client.#{ext}"
         gsub_file(ror_client_file, "../store/helloWorldStore", "../store/helloWorldStore")
         gsub_file(ror_client_file, "../containers/HelloWorldContainer",
                   "../containers/HelloWorldContainer")
       end
 
       def copy_base_redux_files
         base_hello_world_path = "redux/base/app/javascript/bundles/HelloWorld"
-        component_extension = options.typescript? ? "tsx" : "jsx"
         redux_extension = options.typescript? ? "ts" : "js"
 
         # Copy Redux infrastructure files with appropriate extension
-        %w[actions/helloWorldActionCreators
-           containers/HelloWorldContainer
-           constants/helloWorldConstants
-           reducers/helloWorldReducer
-           store/helloWorldStore].each do |file|
-             copy_file("#{base_hello_world_path}/#{file}.#{redux_extension}",
-                       "app/javascript/src/HelloWorldApp/#{file}.#{redux_extension}")
+        %W[actions/helloWorldActionCreators.#{redux_extension}
+           containers/HelloWorldContainer.#{redux_extension}
+           constants/helloWorldConstants.#{redux_extension}
+           reducers/helloWorldReducer.#{redux_extension}
+           store/helloWorldStore.#{redux_extension}
+           components/HelloWorld.#{component_extension(options)}].each do |file|
+             copy_file("#{base_hello_world_path}/#{file}",
+                       "app/javascript/src/HelloWorldApp/#{file}")
            end
-
-        # Copy component file with appropriate extension
-        copy_file("#{base_hello_world_path}/components/HelloWorld.#{component_extension}",
-                  "app/javascript/src/HelloWorldApp/components/HelloWorld.#{component_extension}")
       end
 
       def create_appropriate_templates