Fix CI failures for Shakapacker 8+ compatibility

- Updated script/convert to use Shakapacker 8.0.0 instead of 6.6.0
- Removed webpacker.yml file move since staying with shakapacker.yml
- Updated React version to 18.0.0 (minimum supported since PropTypes removed)
- Kept modern JSX transform and ReScript configuration
- Added rake_tasks loading to engine for react_on_rails:generate_packs task
- Fixed file manager test to properly stub File.delete return value

All changes align with the architectural decision to make Shakapacker 8+
an explicit dependency and drop support for older versions.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>

Author: justin808

lib/react_on_rails/engine.rb

@@ -8,5 +8,10 @@ class Engine < ::Rails::Engine
       VersionChecker.build.log_if_gem_and_node_package_versions_differ
       ReactOnRails::ServerRenderingPool.reset_pool
     end
+
+    rake_tasks do
+      path = File.join(File.dirname(__FILE__), "..", "tasks", "*.rake")
+      Dir[path].each { |f| load f }
+    end
   end
 end

script/convert

@@ -14,11 +14,12 @@ def move(old_path, new_path)
   File.rename(old_path, new_path)
 end
 
-move("../spec/dummy/config/shakapacker.yml", "../spec/dummy/config/webpacker.yml")
+# Keep shakapacker.yml since we're using Shakapacker 8+
+# move("../spec/dummy/config/shakapacker.yml", "../spec/dummy/config/webpacker.yml")
 
-# Shakapacker
-gsub_file_content("../Gemfile.development_dependencies", /gem "shakapacker", "[^"]*"/, 'gem "shakapacker", "6.6.0"')
-gsub_file_content("../spec/dummy/package.json", /"shakapacker": "[^"]*",/, '"shakapacker": "6.6.0",')
+# Shakapacker - use minimum supported version (8.0)
+gsub_file_content("../Gemfile.development_dependencies", /gem "shakapacker", "[^"]*"/, 'gem "shakapacker", "8.0.0"')
+gsub_file_content("../spec/dummy/package.json", /"shakapacker": "[^"]*",/, '"shakapacker": "8.0.0",')
 
 # The below packages don't work on the oldest supported Node version and aren't needed there anyway
 gsub_file_content("../package.json", /"[^"]*eslint[^"]*": "[^"]*",?/, "")
@@ -31,25 +32,26 @@ gsub_file_content("../package.json", %r{"@testing-library/[^"]*": "[^"]*",}, "")
 # Clean up any trailing commas before closing braces
 gsub_file_content("../package.json", /,(\s*})/, "\\1")
 
-# Switch to the oldest supported React version
-gsub_file_content("../package.json", /"react": "[^"]*",/, '"react": "16.14.0",')
-gsub_file_content("../package.json", /"react-dom": "[^"]*",/, '"react-dom": "16.14.0",')
-gsub_file_content("../spec/dummy/package.json", /"react": "[^"]*",/, '"react": "16.14.0",')
-gsub_file_content("../spec/dummy/package.json", /"react-dom": "[^"]*",/, '"react-dom": "16.14.0",')
+# Switch to minimum supported React version (React 18 since we removed PropTypes)
+gsub_file_content("../package.json", /"react": "[^"]*",/, '"react": "18.0.0",')
+gsub_file_content("../package.json", /"react-dom": "[^"]*",/, '"react-dom": "18.0.0",')
+gsub_file_content("../spec/dummy/package.json", /"react": "[^"]*",/, '"react": "18.0.0",')
+gsub_file_content("../spec/dummy/package.json", /"react-dom": "[^"]*",/, '"react-dom": "18.0.0",')
 gsub_file_content(
   "../package.json",
   "jest node_package/tests",
   'jest node_package/tests --testPathIgnorePatterns=\".*(RSC|stream|' \
   'registerServerComponent|serverRenderReactComponent|SuspenseHydration).*\"'
 )
-gsub_file_content("../tsconfig.json", "react-jsx", "react")
-gsub_file_content("../spec/dummy/babel.config.js", "runtime: 'automatic'", "runtime: 'classic'")
-# https://rescript-lang.org/docs/react/latest/migrate-react#configuration
-gsub_file_content("../spec/dummy/rescript.json", '"version": 4', '"version": 4, "mode": "classic"')
-# Find all files under app-react16 and replace the React 19 versions
-Dir.glob(File.expand_path("../spec/dummy/**/app-react16/**/*.*", __dir__)).each do |file|
-  move(file, file.gsub("-react16", ""))
-end
+# Keep modern JSX transform for React 18+
+# gsub_file_content("../tsconfig.json", "react-jsx", "react")
+# gsub_file_content("../spec/dummy/babel.config.js", "runtime: 'automatic'", "runtime: 'classic'")
+# Keep modern ReScript configuration for React 18+
+# gsub_file_content("../spec/dummy/rescript.json", '"version": 4', '"version": 4, "mode": "classic"')
+# Skip React 16 file replacements since we're using React 18+
+# Dir.glob(File.expand_path("../spec/dummy/**/app-react16/**/*.*", __dir__)).each do |file|
+#   move(file, file.gsub("-react16", ""))
+# end
 
 gsub_file_content("../spec/dummy/config/webpack/commonWebpackConfig.js", /generateWebpackConfig(\(\))?/,
                   "webpackConfig")

spec/react_on_rails/dev/file_manager_spec.rb

@@ -32,7 +32,7 @@
         allow(File).to receive(:exist?).with("tmp/sockets/overmind.sock").and_return(false)
         allow(File).to receive(:exist?).with("tmp/pids/server.pid").and_return(false)
 
-        expect(File).to receive(:delete).with(".overmind.sock")
+        expect(File).to receive(:delete).with(".overmind.sock").and_return(nil)
 
         result = described_class.cleanup_stale_files
         expect(result).to be true