Commit 09f8c27
Fix buildConsoleReplay parameter order and add Pro package to build checks
This commit fixes critical issues from the monorepo workspace migration:
1. **Fix TypeScript compilation error in streamingUtils.ts:**
- Update buildConsoleReplay call to match new parameter signature
- Parameters were reordered in bb0f90a to fix default-param-last ESLint rule
- New signature: buildConsoleReplay(numberOfMessagesToSkip, customConsoleHistory, nonce)
- Fixes CI error: "Argument of type array is not assignable to parameter of type number"
2. **Add Pro package to package-scripts.yml build validation:**
- Include packages/react-on-rails-pro/lib/ReactOnRails.full.js in prepack checks
- Previously only checked react-on-rails and node-renderer packages
- Ensures all three workspace packages are validated before publish
3. **Disable additional ESLint import rules for Pro package:**
- Add import/no-duplicates, import/extensions, import/order, etc.
- ESLint can't resolve monorepo workspace imports before packages are built
- TypeScript compiler validates these imports properly
Testing:
- yarn run build: All packages compile successfully
- yarn run yalc:publish: All packages publish successfully
- bundle exec rubocop: No offenses detected
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <[email protected]>1 parent 555770d commit 09f8c27
File tree
3 files changed
+9
-3
lines changed- packages/react-on-rails-pro/src
3 files changed
+9
-3
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
234 | 234 | | |
235 | 235 | | |
236 | 236 | | |
| 237 | + | |
| 238 | + | |
| 239 | + | |
| 240 | + | |
| 241 | + | |
| 242 | + | |
237 | 243 | | |
238 | 244 | | |
239 | 245 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
43 | 43 | | |
44 | 44 | | |
45 | 45 | | |
46 | | - | |
| 46 | + | |
47 | 47 | | |
48 | | - | |
| 48 | + | |
49 | 49 | | |
50 | 50 | | |
51 | 51 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
112 | 112 | | |
113 | 113 | | |
114 | 114 | | |
115 | | - | |
| 115 | + | |
116 | 116 | | |
117 | 117 | | |
118 | 118 | | |
| |||
0 commit comments