Update all dependencies to use local packages in monorepo

AbanoubGhadban · claude · AbanoubGhadban · commit 0a227f9abced · 2025-09-25T19:37:52.000+03:00
- Update react_on_rails_pro gemspec to use local gem dependency - Update development dependencies to use local gem path - Update dummy app package.json to use local npm package - Add CircleCI build-core-package job to build React on Rails package - Share built package via workspace to all pro jobs - Ensure all pro jobs depend on build-core-package for local dependencies 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
diff --git a/.circleci/config.yml b/.circleci/config.yml
@@ -125,13 +125,35 @@ aliases:
         echo -e "\nInstalled $(google-chrome --version)"
       fi
 
+  # Build core React on Rails package for pro package to use
+  - &build-core-package
+    name: Build core React on Rails package
+    command: |
+      yarn install --frozen-lockfile --no-progress --no-emoji
+      yarn run build
+
 jobs:
+  # Build core React on Rails package
+  build-core-package:
+    docker:
+      - image: &docker_image cimg/ruby:3.3.7-browsers
+    steps:
+      - checkout
+      - run: *print-system-info
+      - run: *build-core-package
+      - persist_to_workspace:
+          root: .
+          paths:
+            - node_package/lib
+
   # Lint all
   lint-js-and-ruby:
     docker:
       - image: &docker_image cimg/ruby:3.3.7-browsers
     steps:
       - checkout
+      - attach_workspace:
+          at: .
       - run: *print-system-info
       - restore_cache: *restore-package-node-modules-cache
       - restore_cache: *restore-package-gem-cache
@@ -158,6 +180,8 @@ jobs:
       - image: *docker_image
     steps:
       - checkout
+      - attach_workspace:
+          at: .
       - run: *print-system-info
       - restore_cache: *restore-package-node-modules-cache
       - run: *install-package-node-modules
@@ -173,6 +197,8 @@ jobs:
       - image: *docker_image
     steps:
       - checkout
+      - attach_workspace:
+          at: .
       - run: *print-system-info
       - restore_cache: *restore-dummy-app-node-modules-cache
       - run: *install-package-node-modules
@@ -189,6 +215,8 @@ jobs:
       - image: *docker_image
     steps:
       - checkout
+      - attach_workspace:
+          at: .
       - run: *print-system-info
       - restore_cache: *restore-package-gem-cache
       - run: *install-package-ruby-gems
@@ -204,6 +232,8 @@ jobs:
       - image: *docker_image
     steps:
       - checkout
+      - attach_workspace:
+          at: .
       - run: *print-system-info
       - restore_cache: *restore-dummy-app-gem-cache
       - run: *install-dummy-app-ruby-gems
@@ -221,6 +251,8 @@ jobs:
       - image: *docker_image
     steps:
       - checkout
+      - attach_workspace:
+          at: .
       - run: *print-system-info
       - restore_cache: *restore-package-node-modules-cache
       - restore_cache: *restore-dummy-app-node-modules-cache
@@ -246,6 +278,8 @@ jobs:
       - image: *docker_image
     steps:
       - checkout
+      - attach_workspace:
+          at: .
       - run: *print-system-info
       - restore_cache: *restore-package-node-modules-cache
       - run: rm -rf react_on_rails_pro/spec/dummy/public/webpack
@@ -268,6 +302,8 @@ jobs:
       - image: *docker_image
     steps:
       - checkout
+      - attach_workspace:
+          at: .
       - run: *print-system-info
       - restore_cache: *restore-package-gem-cache
       - run: *install-package-ruby-gems
@@ -291,6 +327,8 @@ jobs:
       - image: *docker_image
     steps:
       - checkout
+      - attach_workspace:
+          at: .
       - run: *print-system-info
       - restore_cache: *restore-package-gem-cache
       - restore_cache: *restore-package-node-modules-cache
@@ -347,30 +385,42 @@ workflows:
   version: 2
   build-and-test:
     jobs:
-      - install-package-node-packages
-      - install-package-ruby-gems
+      - build-core-package
+      - install-package-node-packages:
+          requires:
+            - build-core-package
+      - install-package-ruby-gems:
+          requires:
+            - build-core-package
       - install-dummy-app-node-packages:
           requires:
             - install-package-node-packages
-      - install-dummy-app-ruby-gems
+      - install-dummy-app-ruby-gems:
+          requires:
+            - build-core-package
       - lint-js-and-ruby:
           requires:
+            - build-core-package
             - install-package-node-packages
             - install-package-ruby-gems
             - install-dummy-app-node-packages
       - build-dummy-app-webpack-test-bundles:
           requires:
+            - build-core-package
             - install-package-node-packages
             - install-dummy-app-node-packages
             - install-dummy-app-ruby-gems
       - package-js-tests:
           requires:
+            - build-core-package
             - install-package-node-packages
             - build-dummy-app-webpack-test-bundles
       - rspec-package-specs:
           requires:
+            - build-core-package
             - install-package-ruby-gems
       - rspec-dummy-app-node-renderer:
           requires:
+            - build-core-package
             - install-package-ruby-gems
             - build-dummy-app-webpack-test-bundles
diff --git a/react_on_rails_pro/Gemfile.development_dependencies b/react_on_rails_pro/Gemfile.development_dependencies
@@ -5,11 +5,7 @@ git_source(:github) { |repo| "https://github.com/#{repo}.git" }
 
 ruby '3.3.7'
 
-gem "react_on_rails", "16.1.1"
-
-# For local development
-# Add the following line to the Gemfile.local file
-# gem "react_on_rails", path: "../react_on_rails"
+gem "react_on_rails", path: "../"
 
 gem "shakapacker", "8.0.0"
 gem "bootsnap", require: false
diff --git a/react_on_rails_pro/Gemfile.lock b/react_on_rails_pro/Gemfile.lock
@@ -6,6 +6,17 @@ GIT
       byebug (~> 11.0)
       pry (>= 0.13, < 0.15)
 
+PATH
+  remote: ..
+  specs:
+    react_on_rails (16.1.1)
+      addressable
+      connection_pool
+      execjs (~> 2.5)
+      rails (>= 5.2)
+      rainbow (~> 3.0)
+      shakapacker (>= 6.0)
+
 PATH
   remote: .
   specs:
@@ -288,13 +299,6 @@ GEM
       ffi (~> 1.0)
     rdoc (6.12.0)
       psych (>= 4.0.0)
-    react_on_rails (16.1.1)
-      addressable
-      connection_pool
-      execjs (~> 2.5)
-      rails (>= 5.2)
-      rainbow (~> 3.0)
-      shakapacker (>= 6.0)
     regexp_parser (2.9.2)
     reline (0.6.0)
       io-console (~> 0.5)
@@ -469,7 +473,7 @@ DEPENDENCIES
   pry-theme
   puma (~> 6)
   rails (~> 7.1)
-  react_on_rails (= 16.1.1)
+  react_on_rails!
   react_on_rails_pro!
   rspec-rails
   rspec-retry
diff --git a/react_on_rails_pro/package.json b/react_on_rails_pro/package.json
@@ -85,7 +85,7 @@
     "nps": "^5.9.12",
     "pino-pretty": "^13.0.0",
     "prettier": "^3.2.5",
-    "react-on-rails": "file:../node_package",
+    "react-on-rails": "file:../",
     "redis": "^5.0.1",
     "release-it": "^17.6.0",
     "sentry-testkit": "^5.0.6",
diff --git a/react_on_rails_pro/spec/dummy/Gemfile.lock b/react_on_rails_pro/spec/dummy/Gemfile.lock
@@ -17,6 +17,17 @@ PATH
       rainbow
       react_on_rails (>= 16.0.0)
 
+PATH
+  remote: ../../..
+  specs:
+    react_on_rails (16.1.1)
+      addressable
+      connection_pool
+      execjs (~> 2.5)
+      rails (>= 5.2)
+      rainbow (~> 3.0)
+      shakapacker (>= 6.0)
+
 GEM
   remote: https://rubygems.org/
   specs:
@@ -315,13 +326,6 @@ GEM
       ffi (~> 1.0)
     rdoc (6.12.0)
       psych (>= 4.0.0)
-    react_on_rails (16.1.1)
-      addressable
-      connection_pool
-      execjs (~> 2.5)
-      rails (>= 5.2)
-      rainbow (~> 3.0)
-      shakapacker (>= 6.0)
     redis (5.4.0)
       redis-client (>= 0.22.0)
     redis-client (0.24.0)
@@ -517,7 +521,7 @@ DEPENDENCIES
   pry-theme
   puma (~> 6)
   rails (~> 7.1)
-  react_on_rails (= 16.1.1)
+  react_on_rails!
   react_on_rails_pro!
   redis
   rspec-rails
diff --git a/react_on_rails_pro/spec/dummy/package.json b/react_on_rails_pro/spec/dummy/package.json
@@ -51,7 +51,7 @@
     "react-dom": "19.0.0",
     "react-error-boundary": "^4.1.2",
     "react-helmet": "^6.0.0-beta.2",
-    "react-on-rails": "16.1.1",
+    "react-on-rails": "file:../",
     "react-on-rails-rsc": "^19.0.2",
     "react-proptypes": "^1.0.0",
     "react-redux": "^9.2.0",
diff --git a/react_on_rails_pro/spec/dummy/yarn.lock b/react_on_rails_pro/spec/dummy/yarn.lock
@@ -5353,10 +5353,8 @@ react-on-rails-rsc@^19.0.2:
     neo-async "^2.6.1"
     webpack-sources "^3.2.0"
 
-react-on-rails@16.1.1:
-  version "16.1.1"
-  resolved "https://registry.yarnpkg.com/react-on-rails/-/react-on-rails-16.1.1.tgz#bf5e752c44381252204482342ae5722d9f45f715"
-  integrity sha512-Ntw/4HSB/p9QJ1V2kc0aETzK0W0Vy0suSh0Ugs3Ctfso2ovIT2YUegJJyPtFzX9jUZSR6Q/tkmkgNgzASkO0pw==
+"react-on-rails@file:..":
+  version "0.0.0"
 
 react-proptypes@^1.0.0:
   version "1.0.0"
diff --git a/react_on_rails_pro/yarn.lock b/react_on_rails_pro/yarn.lock
@@ -6843,10 +6843,8 @@ react-is@^18.0.0:
   resolved "https://registry.yarnpkg.com/react-is/-/react-is-18.3.1.tgz#e83557dc12eae63a99e003a46388b1dcbb44db7e"
   integrity sha512-/LLMVyas0ljjAtoYiPqYiL8VWXzUUdThrmU5+n20DZv+a+ClRoevUzw5JxU+Ieh5/c87ytoTBV9G1FiKfNJdmg==
 
-react-on-rails@16.1.1:
+"react-on-rails@file:..":
   version "16.1.1"
-  resolved "https://registry.yarnpkg.com/react-on-rails/-/react-on-rails-16.1.1.tgz#bf5e752c44381252204482342ae5722d9f45f715"
-  integrity sha512-Ntw/4HSB/p9QJ1V2kc0aETzK0W0Vy0suSh0Ugs3Ctfso2ovIT2YUegJJyPtFzX9jUZSR6Q/tkmkgNgzASkO0pw==
 
 readable-stream@^2.2.2:
   version "2.3.8"
